Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:Android:fixes #919

Merged
merged 18 commits into from
Oct 29, 2019
Merged

Fix:Android:fixes #919

merged 18 commits into from
Oct 29, 2019

Conversation

jandegr
Copy link
Contributor

@jandegr jandegr commented Oct 24, 2019

  • Restores the titlebar of the mapdownloadactivity showing available space
  • makes the softkeyboard show up on sdk29 devices
  • untangles the callbackmessagechannel from navitgraphics
  • where receiving intents already worked after Add/Android Supporting sending & receiving geo: intents #812 when navit was not running or running backgrounded with the mapview, this fixes it for splitscreen mode and cases where navit had another activity on top
  • defers graphics updates in case the mapview is not visible

note : Android does not refresh available space often, so after deleting or downloading a map a restart of Navit is sometimes needed to show the correct free space. This is not a Navit issue and I have no idea on how to force Android to update freespace sooner.
A test with getAllocatableBytes() did not solve it.

@jandegr
Copy link
Contributor Author

jandegr commented Oct 24, 2019

Includes backing-up bookmark.txt on a backup account for testing.
expected to work at least on devices >= sdk 23, maybe it can work on older devices too.

Testscenario

  • fresh install of navit on sdk 28 nokia
  • download a map (optional)
  • make some bookmark
  • make the device do a backup (because of no patience to wait for the scheduled backup)
  • check the backupaccount on a desktop to view the backup has happened
  • uninstall navit
  • verify all files effectively are removed
  • fresh install of navit

Do NOT change the default path, the testcenario did not mention doing it but some might be tempted to change it anyway and uninstall navit if one was present on the device to have the fresh install of the first step.

watch logcat

I/Backup: [GmsBackupTransport] Got full restore package: org.navitproject.navit 2019-10-24 20:20:25.699 889-1822/?
I/BackupManagerService: Next restore package: RestoreDescription{org.navitproject.navit : STREAM} 2019-10-24 20:20:25.725 5450-5473/?
I/Backup: [FullRestoreDataProcessorFac] Performing unencrypted restore for org.navitproject.navit
D/BackupManagerService: restoreFinished packageName=org.navitproject.navit
D/BackupManagerService: Restore complete, killing host process of org.navitproject.navit

result : the bookmark is restored right away at install

@jandegr
Copy link
Contributor Author

jandegr commented Oct 25, 2019

tested on

android 4.1.2 (sdk 16) Samsung GT-S5310
android 4.2.2 (sdk 17) Asus me173
android 5.1.1 (sdk 22) SM-J320H STF @pgrandin
android 6.0 (sdk 23) Motorola moto E2
android 7.1.1 (sdk 25) Lenovo moto E4 plus
android 8.0 (sdk 26) Samsung SM-J600G STF @pgrandin
android 9.0 (sdk 28) MI A2 STF @pgrandin
android 9.0 (sdk 28) nokia.
android 10 (sdk 29) AVD

on an android 4.1.2 (sdk 16) Samsung GT-S5310
device-2019-10-25-105804

@jandegr jandegr marked this pull request as ready for review October 25, 2019 09:23
update sizes and cleanup
@jandegr
Copy link
Contributor Author

jandegr commented Oct 29, 2019

Last addition for this PR, some work on the mapdownloader

  • updates the estimated sizes of the predefined area's
  • some cleanup
  • the predefined area western europe is disabled, it contains more than the europe area where western europe should be a portion of europe
  • the predefined area of france also contains belgium and luxembourg, changed the name to make that clear
  • added a new area france + luxembourg, over 500MB smaller than the version including belgium completely

@pgrandin pgrandin merged commit aefa85d into navit-gps:trunk Oct 29, 2019
@jandegr jandegr deleted the patch-1 branch October 29, 2019 16:13
hoehnp pushed a commit that referenced this pull request Nov 4, 2019
viktorgino pushed a commit that referenced this pull request Sep 22, 2020
jkoan pushed a commit to jkoan/navit that referenced this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants