Add support for Symfony 6

[Chris53897]

update travis.yml

Not tested in real life app.

Is is easier for dev to have "symfony/filesystem": "^4.4|^5.0|^6.0", installed and check if it is correct by IDE or static code analyzer.

[Chris53897]

@maxbaldanza
Hi. Is there any news on this PR?

[maxbaldanza]

@maxbaldanza Hi. Is there any news on this PR?

Hi Chris,

Sorry just seen this, any chance you can rebase as there's some merge conflicts and I'll take a look?

Appreciate the contribution 👍

[maxbaldanza]

@Chris53897, we have an old Legacy project that currently supports Symfony 3 so we need to keep that at the minute.
We are in the process of updating it but for the time being we need to keep that support to avoid having to maintain two separate versions.
Happy for Symfony 6 to be added though

[Chris53897]

I have deleted the file .travis. Merge-Conflict should be gone now.
Composer will handle the legacy version for you. So it still will works.
But of course let me know after you have migrated the legacy project.

[maxbaldanza]

I have deleted the file .travis. Merge-Conflict should be gone now. Composer will handle the legacy version for you. So it still will works. But of course let me know after you have migrated the legacy project.

It will handle it but if there's any updates to make we'd need to make them to both versions which means more maintenance on our part which I want to try avoid.

I'd prefer to keep Symfony 3 until we've migrated and then remove the support at a later date.

[maxbaldanza]

Can you please add Symfony 6 to the versions here please? https://github.com/mybuilder/cronos/blob/master/.github/workflows/test.yml#L12
We're now using github actions for testing rather than travis

[Chris53897]

Update: sorry i did read this wrong. I will change it

[maxbaldanza]

Can you update your branch and add Symfony 6 to the linked github action please?

[Chris53897]

The github actions needs more changes. Only adding 6.0.0 to the matrix will fail.
https://github.com/Chris53897/cronos/actions/runs/3463286751/jobs/5783304065

[maxbaldanza]

Ah of course Symfony 6 requires PHP8.
If you have time to update the action then that would be good. If not, then take it out for now and I'll update it when I get a chance

[Chris53897]

I will try to find some time after my vacation. Should not be so hard, i guess.
Something like this.
matrix: include:
https://github.com/Chris53897/KnpMenuBundle/blob/master/.github/workflows/build.yaml

[maxbaldanza]

Thank you, enjoy your holiday 😎
Something like that matrix would work yes 👍

[Chris53897]

Thanks. I have adjusted the ci-tests.
And i changed composer.json to "^3.4|^4.4|^5.4|^6.0", as supported LTS.
Additional i fixed a deprecation message of the ci.

If you want more or other test runs, please let me know or change it to your needs.

[scrutinizer-notifier]

A new inspection was created.

[scrutinizer-notifier]

The inspection completed: ****

[scrutinizer-notifier]

A new inspection was created.

[scrutinizer-notifier]

The inspection completed: ****

[maxbaldanza]

Thank you very much for this. Really appreciate the contribution 👍
You'll be happy to know we no longer need to support Symfony 3.4 but I can remove that at a later date or if you want to create a new PR then your very welcome to

[Chris53897]

That are good news.
Symfony 4.4 is no more the current LTS.
https://symfony.com/releases/4.4

Should i support 4.4 in the new PR?

[maxbaldanza]

That are good news. Symfony 4.4 is no more the current LTS. https://symfony.com/releases/4.4

Should i support 4.4 in the new PR?

It's still getting security fixes until the end of the year so I'd prefer to leave it in.
Happy to drop support for PHP7 though as that's no longer supported 👍

[Chris53897]

I will extend my PR and drop support of php 8