Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop support of symfony < 4.4. add support of symfony 6 #42

Merged
merged 10 commits into from
Jan 4, 2023
Merged

feat: drop support of symfony < 4.4. add support of symfony 6 #42

merged 10 commits into from
Jan 4, 2023

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Aug 20, 2022 •
edited
Loading

See: mybuilder/cronos#27
#41

Not tested in real life app.

@Chris53897 Chris53897 mentioned this pull request Nov 14, 2022
Closed
maxbaldanza
maxbaldanza reviewed Jan 3, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
maxbaldanza
maxbaldanza reviewed Jan 3, 2023
View reviewed changes
README.md Show resolved Hide resolved
maxbaldanza
maxbaldanza reviewed Jan 3, 2023
View reviewed changes
Copy link
Contributor

@maxbaldanza maxbaldanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 if we can remove Symfony 3 from docs as it's no longer supported then all good

README.md Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
Chris53897 and others added 3 commits January 3, 2023 22:09
@Chris53897 @maxbaldanza
Update composer.json
e0d9e91 
Co-authored-by: Max Baldanza <maxbaldanza@googlemail.com>
@Chris53897 @maxbaldanza
Update README.md
082f4b1 
Co-authored-by: Max Baldanza <maxbaldanza@googlemail.com>
@Chris8934
feat: allow symfony 6, drop support of symfony < 4.4, adjust ci tests…
d857fec 
…, adjust README.md, set type of bundle for composer
@Chris53897
Copy link
Contributor Author

With the composer type set to symfony-bundle, Symfony Flex handle the entry in config/bundles.php
I adjusted the README.md

After that is merged, can i create a new PR to drop support of php 7?

@scrutinizer-notifier
Copy link

A new inspection was created.

@scrutinizer-notifier
Copy link

The inspection completed: ****

maxbaldanza
maxbaldanza approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@maxbaldanza maxbaldanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help 👍

@maxbaldanza maxbaldanza merged commit 887fa15 into mybuilder:master Jan 4, 2023
@maxbaldanza
Copy link
Contributor

After that is merged, can i create a new PR to drop support of php 7?

Yes happy to do that 👍 thank you

@Chris53897 Chris53897 deleted the feature/symfony-6 branch January 4, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbaldanza maxbaldanza maxbaldanza approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chris53897 @scrutinizer-notifier @maxbaldanza @Chris8934