Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop support of symfony < 4.4, drop support of php 7 #33

Merged
merged 7 commits into from
Jan 3, 2023
Merged

feat: drop support of symfony < 4.4, drop support of php 7 #33

merged 7 commits into from
Jan 3, 2023

Conversation

Chris53897
Copy link
Contributor

@maxbaldanza
Copy link
Contributor

Looks good, could you please just remove Symfony 3 from the readme too?

@Chris53897
Copy link
Contributor Author

Looks good, could you please just remove Symfony 3 from the readme too?

I can do this. But 3 is kind of correct. Older versions will still work. Should i remove it?

@Chris53897 Chris53897 changed the title feat: drop support of symfony < 4.4 feat: drop support of symfony < 4.4, drop support of php 7 Jan 3, 2023
@Chris53897
Copy link
Contributor Author

I removed the security bundle. This should be handled by composer audit in users project in my eyes. https://php.watch/articles/composer-24#audit

@Chris53897
Copy link
Contributor Author

I changed the namespace of test-classes. PhpStorm was nagging me, that they are wrong.

maxbaldanza
maxbaldanza requested changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@maxbaldanza maxbaldanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help here but I've noticed a few small things

@maxbaldanza
Copy link
Contributor

I can do this. But 3 is kind of correct. Older versions will still work. Should i remove it?

Yeah I think so as it's not a version that would be in the current support

Chris53897 and others added 5 commits January 3, 2023 17:29
@Chris53897 @maxbaldanza
Update src/Formatter/Header.php
27e312f 
Co-authored-by: Max Baldanza <maxbaldanza@googlemail.com>
@Chris53897 @maxbaldanza
Update src/Formatter/Output.php
5b78729 
Co-authored-by: Max Baldanza <maxbaldanza@googlemail.com>
@Chris53897 @maxbaldanza
Update src/Formatter/Output.php
747a422 
Co-authored-by: Max Baldanza <maxbaldanza@googlemail.com>
@Chris8934
feat: drop support of symfony < 4.4, drop support of php 7
aaf2c78
@maxbaldanza
Run further Symfony versions in PHP8.1
1ebda69
@scrutinizer-notifier
Copy link

A new inspection was created.

@scrutinizer-notifier
Copy link

The inspection completed: ****

maxbaldanza
maxbaldanza approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@maxbaldanza maxbaldanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes 🙌

@maxbaldanza maxbaldanza merged commit 1019a39 into mybuilder:master Jan 3, 2023
@Chris53897 Chris53897 deleted the feature/drop-sopport-of-symfony-3 branch January 3, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbaldanza maxbaldanza maxbaldanza approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chris53897 @maxbaldanza @scrutinizer-notifier @Chris8934