Feat/multiple p2p messengers #5345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents to create and manage both messengers added new fullArchiveP2P.toml file(for the moment just a copy of p2p.toml) + new flags removed MetricP2PFullHistoryObservers which won't be needed anymore removed FullHistoryList from diffPeerListCreator as it won't be needed anymore added the needed disabled components added todos for further implementation
… fixes were made there
Manage multiple network messengers on network components
…well added todos for further implementation
small refactor on antiflood components creation created a new full history peer shard mapper create new interceptors for heartbeat to feed the new peer shard mapper
Full archive heartbeat sender + new data pools
…or_fullarchive_messenger
added separate preferred peers holder for the new network
Full archive integration test
…//github.com/multiversx/mx-chain-go into requesters_resolvers_full_archive_network # Conflicts: # factory/processing/processComponents.go # factory/processing/processComponentsHandler_test.go # integrationTests/multiShard/hardFork/hardFork_test.go # update/factory/exportHandlerFactory.go
fix race in tests
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5345 +/- ##
=============================================
+ Coverage 80.00% 80.09% +0.08%
=============================================
Files 704 704
Lines 92814 93153 +339
=============================================
+ Hits 74260 74613 +353
+ Misses 13240 13228 -12
+ Partials 5314 5312 -2
☔ View full report in Codecov by Sentry. |
…into merge_rc160_into_feat_multiple_p2p_messengers_2023.07.07 # Conflicts: # errors/errors.go # factory/mock/processComponentsStub.go # factory/processing/processComponents.go # go.mod # integrationTests/mock/processComponentsStub.go
…le_p2p_messengers_2023.07.07 Merge rc160 into feat multiple p2p messengers 2023.07.07
…into feat/multiple_p2p_messengers # Conflicts: # process/transaction/shardProcess_test.go
…le_p2p_messengers_2023.07.10 Merge rc160 into feat multiple p2p messengers 2023.07.10
…n_go Update mx chain communication go
Updated mx-chain-communication-go with NetworkType
update mx chain communication go
…into merge_rc160_into_feat_multiple_p2p_messengers # Conflicts: # api/groups/nodeGroup.go # go.mod
…le_p2p_messengers Merge rc160 into feat multiple p2p messengers
gabi-vuls
previously approved these changes
Jul 21, 2023
There was a problem hiding this comment.
@@ Log scanner @@
feat/multiple_p2p_messengers
================================================================================
- Known Warnings 14
- New Warnings 4
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================ - block hash does not match 8598
- wrong nonce in block 3836
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 0
================================================================================ - No jailed nodes on the testnet
================================================================================
ssd04
previously approved these changes
Jul 21, 2023
bogdan-rosianu
previously approved these changes
Jul 21, 2023
Update mx-chain-communication-go tag
33486c2
ssd04
approved these changes
Jul 21, 2023
bogdan-rosianu
approved these changes
Jul 21, 2023
gabi-vuls
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
This feature is a complete refactoring for the full archive solution. The old solution was based on the idea that full archive nodes would still connect on the p2p network by overriding the sharding counters but in practice, it did not perform well. This new solution relies on a secondary, optional p2p network on which only the full archive nodes will join.
Since this network will mostly contain full archive nodes, the connection between the nodes and the cycles
request-response will be optimized.
Testing procedure
seednode/config/p2p.toml) for the new network(eg. erd/kad/1.0.1)Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?