Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mx-chain-communication-go with NetworkType #5435

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

  • update dep with latest changes

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Jul 13, 2023
@sstanculeanu sstanculeanu self-assigned this Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01 ⚠️

Comparison is base (de460ed) 80.06% compared to head (04dbd6b) 80.06%.

❗ Current head 04dbd6b differs from pull request most recent head 8186ad1. Consider uploading reports for the commit 8186ad1 to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feat/multiple_p2p_messengers    #5435      +/-   ##
================================================================
- Coverage                         80.06%   80.06%   -0.01%     
================================================================
  Files                               703      703              
  Lines                             93006    93007       +1     
================================================================
- Hits                              74466    74462       -4     
- Misses                            13226    13230       +4     
- Partials                           5314     5315       +1     
Impacted Files Coverage Δ
factory/network/networkComponents.go 88.30% <66.66%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

iulianpascalau
iulianpascalau previously approved these changes Jul 13, 2023
@sstanculeanu sstanculeanu merged commit e111411 into feat/multiple_p2p_messengers Jul 13, 2023
@sstanculeanu sstanculeanu deleted the update_communication_go branch July 13, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants