Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix race in tests #5379

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix race in tests #5379

merged 1 commit into from
Jun 27, 2023

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Jun 27, 2023
@sstanculeanu sstanculeanu self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 71.20% and project coverage change: -0.29 ⚠️

Comparison is base (b3641d1) 80.31% compared to head (5d52c53) 80.03%.

❗ Current head 5d52c53 differs from pull request most recent head afb6675. Consider uploading reports for the commit afb6675 to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feat/multiple_p2p_messengers    #5379      +/-   ##
================================================================
- Coverage                         80.31%   80.03%   -0.29%     
================================================================
  Files                               695      704       +9     
  Lines                             90470    92968    +2498     
================================================================
+ Hits                              72663    74409    +1746     
- Misses                            12638    13242     +604     
- Partials                           5169     5317     +148     
Impacted Files Coverage Δ
cmd/assessment/benchmarks/erc20Benchmark.go 0.00% <ø> (ø)
cmd/assessment/benchmarks/wasmBenchmark.go 0.00% <ø> (ø)
factory/core/coreComponentsHandler.go 80.82% <0.00%> (-2.28%) ⬇️
genesis/process/genesisBlockCreator.go 65.76% <0.00%> (-0.36%) ⬇️
outport/notifier/eventNotifier.go 75.00% <0.00%> (-5.00%) ⬇️
process/common.go 73.92% <0.00%> (-1.08%) ⬇️
...ess/smartContract/processProxy/testProcessProxy.go 0.00% <0.00%> (ø)
process/smartContract/scrCommon/common.go 0.00% <0.00%> (ø)
vm/process/systemVM.go 60.00% <ø> (ø)
process/smartContract/hooks/blockChainHook.go 92.64% <6.25%> (-3.10%) ⬇️
... and 38 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dragos-rebegea dragos-rebegea self-requested a review June 27, 2023 10:02
@sstanculeanu sstanculeanu merged commit 75ce707 into feat/multiple_p2p_messengers Jun 27, 2023
@sstanculeanu sstanculeanu deleted the fix_tests branch June 27, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants