Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rc 1.6.0 trie sync optimizations #5293

Merged

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented May 29, 2023

Reasoning behind the pull request

  • N/A

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

ssd04 and others added 30 commits March 31, 2023 12:14
add marshaller type for notifier to external config
…-missing-trie-nodes-3apr

Merge rc/v1.6.0 in feat/sync missing trie nodes 3apr
# Conflicts:
#	cmd/node/config/enableEpochs.toml
#	common/enablers/enableEpochsHandler.go
#	common/enablers/enableEpochsHandler_test.go
#	common/enablers/epochFlags.go
#	common/interface.go
#	config/epochConfig.go
#	config/tomlConfig_test.go
#	go.mod
#	go.sum
#	sharding/mock/enableEpochsHandlerMock.go
#	testscommon/enableEpochsHandlerStub.go
bogdan-rosianu and others added 23 commits May 25, 2023 10:57
…ith_p2p

Integrate communication go with p2p
…alues-length-checks

Mx 13962 consistent tokens values length checks
…mi-int-test

added semi-integration test for relayed v2 multi nft transfers
…into dataretriever_tests

# Conflicts:
#	testscommon/storageManager/storageManagerStub.go
@ssd04 ssd04 self-assigned this May 29, 2023
@BeniaminDrasovean BeniaminDrasovean self-requested a review May 29, 2023 12:08
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 79.09% and project coverage change: +0.98 🎉

Comparison is base (d7b870c) 79.04% compared to head (8564685) 80.03%.

❗ Current head 8564685 differs from pull request most recent head 1798719. Consider uploading reports for the commit 1798719 to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feat/trie-sync-optimizations    #5293      +/-   ##
================================================================
+ Coverage                         79.04%   80.03%   +0.98%     
================================================================
  Files                               683      691       +8     
  Lines                             88377    89207     +830     
================================================================
+ Hits                              69859    71395    +1536     
+ Misses                            13309    12685     -624     
+ Partials                           5209     5127      -82     
Impacted Files Coverage Δ
api/groups/blockGroup.go 97.95% <ø> (ø)
api/middleware/responseLogger.go 66.66% <0.00%> (ø)
cmd/keygenerator/converter/pidPubkeyConverter.go 90.47% <ø> (ø)
consensus/spos/bls/subroundStartRound.go 68.36% <0.00%> (ø)
...ataRetriever/dataPool/headersCache/headersCache.go 90.15% <ø> (+10.60%) ⬆️
epochStart/shardchain/trigger.go 65.89% <0.00%> (ø)
factory/core/coreComponents.go 90.19% <ø> (ø)
node/external/nodeApiResolver.go 66.42% <0.00%> (ø)
...port/process/transactionsfee/transactionChecker.go 90.00% <ø> (ø)
...rocess/transactionsfee/transactionsFeeProcessor.go 88.34% <ø> (+0.23%) ⬆️
... and 77 more

... and 51 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssd04 ssd04 merged commit 53f43fc into feat/trie-sync-optimizations May 29, 2023
@ssd04 ssd04 deleted the merge-rc-1.6.0-trie-sync-optimizations branch May 29, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants