Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added semi-integration test for relayed v2 multi nft transfers #5177

Merged
merged 5 commits into from
May 25, 2023

Conversation

bogdan-rosianu
Copy link
Contributor

Reasoning behind the pull request

  • there was no integration test with such scenarios

Proposed changes

  • added a semi-integration test that covers multiple situations of multi tokens transfers via relayed v2

Testing procedure

  • n/a

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@bogdan-rosianu bogdan-rosianu added the ignore-for-release-notes Do not include item in release notes label Apr 19, 2023
@bogdan-rosianu bogdan-rosianu self-assigned this Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (50a3d8a) 79.41% compared to head (341e430) 79.41%.

❗ Current head 341e430 differs from pull request most recent head 26ace54. Consider uploading reports for the commit 26ace54 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.6.0    #5177      +/-   ##
=============================================
- Coverage      79.41%   79.41%   -0.01%     
=============================================
  Files            691      691              
  Lines          89197    89197              
=============================================
- Hits           70839    70836       -3     
- Misses         13162    13165       +3     
  Partials        5196     5196              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdan-rosianu bogdan-rosianu merged commit b7dd36b into rc/v1.6.0 May 25, 2023
@bogdan-rosianu bogdan-rosianu deleted the relayed-v2-multi-transfer-semi-int-test branch May 25, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants