Integrate communication go with p2p #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain-communication-go
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5267 +/- ##
==========================================
Coverage 79.41% 79.41%
==========================================
Files 691 691
Lines 89193 89193
==========================================
+ Hits 70835 70837 +2
+ Misses 13162 13161 -1
+ Partials 5196 5195 -1 ☔ View full report in Codecov by Sentry. |
BeniaminDrasovean
previously approved these changes
May 24, 2023
go.mod
Outdated
| @@ -13,12 +13,11 @@ require ( | |||
| github.com/google/gops v0.3.18 | |||
| github.com/gorilla/websocket v1.5.0 | |||
| github.com/mitchellh/mapstructure v1.5.0 | |||
| github.com/multiversx/mx-chain-communication-go v1.0.0 | |||
| github.com/multiversx/mx-chain-communication-go v1.0.1-0.20230522155438-b9bc3ba7183f | |||
There was a problem hiding this comment.
proper tag before merging
gabi-vuls
previously approved these changes
May 24, 2023
There was a problem hiding this comment.
System test passed. ("all in" test + half-half test are passed)
@@ Log scanner @@
integrate_communication-go_with_p2p
================================================================================
- Known Warnings 0
- New Warnings 0
- Known Errors 0
- New Errors 1
- Panics 0
================================================================================ - block hash does not match 2070
- wrong nonce in block 777
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 0
================================================================================ - No jailed nodes on the testnet
================================================================================
…into integrate_communication-go_with_p2p # Conflicts: # go.mod # go.sum
261a975
gabi-vuls
approved these changes
May 25, 2023
bogdan-rosianu
approved these changes
May 25, 2023
BeniaminDrasovean
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?