Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v1.4.0 feat/p2p-separate-repo #4503

Merged
merged 82 commits into from
Sep 22, 2022

Conversation

iulianpascalau
Copy link
Contributor

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • merge

Proposed Changes

  • merge

Testing procedure

  • none

AdoAdoAdo and others added 30 commits July 15, 2022 17:52
move components mock to testscommon
- temporary mock for multisigner
- unit tests
- temp elrond-go-crypto version
# Conflicts:
#	factory/crypto/cryptoComponentsHandler_test.go
#	factory/crypto/cryptoComponents_test.go
ssd04 and others added 22 commits September 20, 2022 10:33
# Conflicts:
#	cmd/node/config/enableEpochs.toml
#	config/epochConfig.go
#	config/tomlConfig_test.go
#	errors/errors.go
#	factory/bootstrap/bootstrapComponents.go
#	factory/bootstrap/bootstrapComponentsHandler.go
#	factory/consensus/consensusComponents.go
#	factory/consensus/consensusComponents_test.go
#	factory/core/coreComponents.go
#	factory/coreComponents_test.go
#	factory/crypto/cryptoComponents.go
#	factory/heartbeat/heartbeatComponents.go
#	factory/heartbeat/heartbeatV2Components.go
#	factory/heartbeatComponents_test.go
#	factory/networkComponents_test.go
#	factory/processComponents_test.go
#	factory/state/stateComponents.go
#	factory/stateComponents_test.go
#	integrationTests/consensus/testInitializer.go
#	integrationTests/factory/consensusComponents/consensusComponents_test.go
#	integrationTests/factory/processComponents/processComponents_test.go
#	integrationTests/factory/statusComponents/statusComponents_test.go
#	integrationTests/testProcessorNodeWithCoordinator.go
#	integrationTests/testProcessorNodeWithMultisigner.go
#	node/nodeRunner.go
#	process/errors.go
#	testscommon/mainFactoryMocks/bootstrapComponentsStub.go
# Conflicts:
#	config/tomlConfig_test.go
#	factory/consensus/consensusComponents.go
…-key-for-p2p

Merge v1.4.0 into load private key for p2p
# Conflicts:
#	cmd/seednode/main.go
#	config/p2pConfig.go
#	factory/network/networkComponents.go
#	factory/networkComponents_test.go
#	p2p/libp2p/netMessenger.go
#	p2p/libp2p/netMessenger_test.go
#	p2p/libp2p/p2pSigner.go
#	p2p/libp2p/p2pSigner_test.go
@iulianpascalau iulianpascalau added the ignore-for-release-notes Do not include item in release notes label Sep 22, 2022
@iulianpascalau iulianpascalau marked this pull request as ready for review September 22, 2022 16:57
@codecov-commenter
Copy link

Codecov Report

Base: 72.97% // Head: 70.74% // Decreases project coverage by -2.23% ⚠️

Coverage data is based on head (07c3fb0) compared to base (49c6b5f).
Patch coverage: 58.96% of modified lines in pull request are covered.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/p2p-separate-repo    #4503      +/-   ##
==========================================================
- Coverage                   72.97%   70.74%   -2.24%     
==========================================================
  Files                         620      623       +3     
  Lines                       82927    83231     +304     
==========================================================
- Hits                        60519    58878    -1641     
- Misses                      17644    19951    +2307     
+ Partials                     4764     4402     -362     
Impacted Files Coverage Δ
common/configParser.go 22.61% <0.00%> (-4.15%) ⬇️
factory/api/apiResolverFactory.go 0.00% <0.00%> (ø)
factory/bootstrap/bootstrapComponents.go 0.00% <0.00%> (ø)
factory/bootstrap/bootstrapComponentsHandler.go 0.00% <0.00%> (ø)
factory/bootstrap/bootstrapParameters.go 0.00% <ø> (ø)
factory/bootstrap/shardingFactory.go 0.00% <0.00%> (ø)
...actory/bootstrap/testBootstrapComponentsHandler.go 0.00% <0.00%> (ø)
factory/consensus/consensusComponents.go 0.00% <0.00%> (ø)
factory/consensus/consensusComponentsHandler.go 0.00% <0.00%> (ø)
factory/core/coreComponents.go 0.00% <ø> (ø)
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iulianpascalau iulianpascalau merged commit d007840 into feat/p2p-separate-repo Sep 22, 2022
@iulianpascalau iulianpascalau deleted the merge-v1.4.0-2022.09.22 branch September 22, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants