Update bls multisigner #4318
Merged
Update bls multisigner #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # factory/crypto/cryptoComponentsHandler_test.go # factory/crypto/cryptoComponents_test.go
Codecov Report
@@ Coverage Diff @@
## feat/kosk-bls-multisigner #4318 +/- ##
============================================================
Coverage ? 71.52%
============================================================
Files ? 665
Lines ? 86171
Branches ? 0
============================================================
Hits ? 61637
Misses ? 20122
Partials ? 4412 Continue to review full report at Codecov.
|
ssd04
reviewed
Jul 25, 2022
ssd04
previously approved these changes
Jul 27, 2022
raduchis
reviewed
Jul 28, 2022
| @@ -100,7 +100,11 @@ func checkBaseParams( | |||
| if coreComponents.MinTransactionVersion() == 0 { | |||
| return process.ErrInvalidTransactionVersion | |||
| } | |||
| if check.IfNil(cryptoComponents.MultiSigner()) { | |||
| multiSigner, err := cryptoComponents.GetMultiSigner(0) | |||
There was a problem hiding this comment.
no need for backwards compatibility flags because the node does not start, right?
raduchis
previously approved these changes
Jul 28, 2022
| return c, nil | ||
| } | ||
|
|
||
| // GetMultiSigner returns the multiSignerContainer configured for the given epoch |
There was a problem hiding this comment.
Suggested change
| // GetMultiSigner returns the multiSignerContainer configured for the given epoch | |
| // GetMultiSigner returns the multiSigner configured for the given epoch |
| return c.multiSigners[i].multiSigner, nil | ||
| } | ||
| } | ||
| return nil, errors.ErrMissingMultiSignerConfig |
There was a problem hiding this comment.
is this error correct? perhaps something more specific?
There was a problem hiding this comment.
changed to signal that a multisigner instance is missing
sstanculeanu
approved these changes
Jul 29, 2022
raduchis
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates in elrond-go a transition of the used BLS multisigner from the one with embedded rogue key protection to the one relying on the knowledge of secret key (which is ensured through the node staking procedure).
For backwards compatibility both multi-signers need to be defined, as the produced signatures differ. For this reason a container was created for holding the versions of multisigners while allowing selection based on the epoch.
The configuration of the multisigner is extended with an epoch activation config.