factory crypto: error and comments updates

multiversx · Jul 29, 2022 · 9f378a5 · 9f378a5
1 parent bb6e447
commit 9f378a5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/errors/errors.go b/errors/errors.go
@@ -485,6 +485,9 @@ var ErrSignerNotSupported = errors.New("signer not supported")
 // ErrMissingMultiSignerConfig signals that the multisigner config is missing
 var ErrMissingMultiSignerConfig = errors.New("multisigner configuration missing")
 
+// ErrMissingMultiSigner signals that there is no multisigner instance available
+var ErrMissingMultiSigner = errors.New("multisigner instance missing")
+
 // ErrMissingEpochZeroMultiSignerConfig signals that the multisigner config for epoch zero is missing
 var ErrMissingEpochZeroMultiSignerConfig = errors.New("multisigner configuration missing for epoch zero")
 

diff --git a/factory/crypto/multiSignerContainer.go b/factory/crypto/multiSignerContainer.go
@@ -70,7 +70,7 @@ func NewMultiSignerContainer(args MultiSigArgs, multiSignerConfig []config.Multi
 	return c, nil
 }
 
-// GetMultiSigner returns the multiSignerContainer configured for the given epoch
+// GetMultiSigner returns the multiSigner configured for the given epoch
 func (c *container) GetMultiSigner(epoch uint32) (crypto.MultiSigner, error) {
 	c.mutSigners.RLock()
 	defer c.mutSigners.RUnlock()
@@ -80,7 +80,7 @@ func (c *container) GetMultiSigner(epoch uint32) (crypto.MultiSigner, error) {
 			return c.multiSigners[i].multiSigner, nil
 		}
 	}
-	return nil, errors.ErrMissingMultiSignerConfig
+	return nil, errors.ErrMissingMultiSigner
 }
 
 // IsInterfaceNil returns true if the underlying object is nil

diff --git a/factory/crypto/multiSignerContainer_test.go b/factory/crypto/multiSignerContainer_test.go
@@ -64,7 +64,7 @@ func TestContainer_GetMultiSigner(t *testing.T) {
 
 		multiSigner, err := multiSigContainer.GetMultiSigner(0)
 		require.Nil(t, multiSigner)
-		require.Equal(t, errors.ErrMissingMultiSignerConfig, err)
+		require.Equal(t, errors.ErrMissingMultiSigner, err)
 	})
 	t.Run("get multi signer OK", func(t *testing.T) {
 		multiSigContainer, _ := NewMultiSignerContainer(args, multiSigConfig)