Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v1.4.0 feat kosk 210922 #4494

Merged
merged 60 commits into from
Sep 22, 2022

Conversation

AdoAdoAdo
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo commented Sep 21, 2022

Description of the reasoning behind the pull request

merge PR
fix one integration test

Proposed Changes

update branch with latest changes
fix signature mock to respect the set size.

BeniaminDrasovean and others added 30 commits July 18, 2022 12:18
…snapshot-nodes

# Conflicts:
#	common/interface.go
#	integrationTests/state/stateTrieSync/stateTrieSync_test.go
#	state/accountsDB.go
#	state/accountsDB_test.go
#	state/peerAccountsDB.go
#	state/peerAccountsDB_test.go
#	testscommon/storageManagerStub.go
#	testscommon/trie/trieStub.go
#	trie/patriciaMerkleTrie_test.go
#	trie/trieStorageManager.go
#	trie/trieStorageManagerWithoutCheckpoints.go
#	trie/trieStorageManagerWithoutCheckpoints_test.go
#	trie/trieStorageManagerWithoutPruning.go
#	trie/trieStorageManagerWithoutPruning_test.go
#	trie/trieStorageManager_test.go
change label name to ignore-for-release-notes
…pshot-nodes

# Conflicts:
#	testscommon/trie/trieStub.go
…pshot-nodes

# Conflicts:
#	integrationTests/testProcessorNode.go
…pshot-nodes

# Conflicts:
#	state/accountsDB.go
#	state/accountsDB_test.go
#	state/peerAccountsDB.go
#	trie/trieStorageManager.go
iulianpascalau and others added 22 commits September 19, 2022 11:29
…pshot-nodes

# Conflicts:
#	node/nodeRunner.go
# Conflicts:
#	cmd/node/config/enableEpochs.toml
#	config/epochConfig.go
#	config/tomlConfig_test.go
#	go.mod
#	go.sum
#	integrationTests/multiShard/smartContract/polynetworkbridge/bridge_test.go
#	node/nodeRunner.go
#	process/smartContract/process.go
#	process/smartContract/process_test.go
#	storage/factory/pruningStorerFactory.go
# Conflicts:
#	config/tomlConfig_test.go
#	factory/consensus/consensusComponents.go
@AdoAdoAdo AdoAdoAdo changed the base branch from master to feat/kosk-bls-multisigner September 21, 2022 15:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Base: 71.27% // Head: 71.18% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (1e290d8) compared to base (92fa342).
Patch coverage: 50.86% of modified lines in pull request are covered.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat/kosk-bls-multisigner    #4494      +/-   ##
=============================================================
- Coverage                      71.27%   71.18%   -0.09%     
=============================================================
  Files                            658      662       +4     
  Lines                          85654    85839     +185     
=============================================================
+ Hits                           61047    61104      +57     
- Misses                         20127    20243     +116     
- Partials                        4480     4492      +12     
Impacted Files Coverage Δ
factory/consensus/consensusComponents.go 0.00% <0.00%> (ø)
node/nodeRunner.go 0.00% <0.00%> (ø)
process/txsimulator/wrappedAccountsDB.go 65.38% <0.00%> (-5.45%) ⬇️
state/accountsDBApi.go 91.45% <0.00%> (-3.24%) ⬇️
state/accountsDBApiWithHistory.go 89.21% <0.00%> (-3.65%) ⬇️
state/errors.go 50.00% <ø> (ø)
trie/keyBuilder/disabledKeyBuilder.go 0.00% <0.00%> (ø)
trie/trieStorageManagerWithoutCheckpoints.go 83.33% <ø> (ø)
trie/extensionNode.go 70.46% <30.76%> (-0.93%) ⬇️
trie/branchNode.go 78.26% <50.00%> (-0.55%) ⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AdoAdoAdo AdoAdoAdo merged commit 94b10b3 into feat/kosk-bls-multisigner Sep 22, 2022
@AdoAdoAdo AdoAdoAdo deleted the merge-v1.4.0-feat-kosk-210922 branch September 22, 2022 05:50
@schimih schimih added the ignore-for-release-notes Do not include item in release notes label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants