-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add base256emoji #88
Conversation
Hm. My first thought is that the readme needs some pithy examples. Other than that ✔️. |
I love this! A note: you use 🚀 both as "multibase prefix" and as "digit 0", perhaps disambiguating the two is worthwhile 🤷 |
I don't really get why that an issue, whats the rational behind this ?
Would swapping 🚀 (0) and 🪐 (5) in the table by enough of a fix ? |
No, I meant have 🚀 mean exclusively "this string is a mojibase encoding" and use 256 other distinct emojis used for the encoding. So all in all you will have 257 defined "atoms". I do not have a solid rationale for this, just feels "cleaner", given you character set is virtually unconstrained. |
I have two counter arguments :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General emoji choice comments. I'd also consider trying to make emoji's as unique as possible.
(I mean, if we're going to paint the bikeshed, we might as well paint it well)
The only real usecase I see is NFT artists bruteforcing cool emoji patern for their collection. So I belive we need rockets and moons. But if anyone has thought thru propositions I'm for it. |
I'm also in favour of using an emoji as prefix which is in the set of the 256 emojis
It is not and I hope it's used less and less. It causes more trouble then good. The only use case I see is for data where the hash is bigger than the actual data. Though even then you're probably better off with other solutions, e.g. combining some of your data into bigger chunks. |
@Jorropo : are you able to incorporate the input here, particularly around not supported emojis? |
Yes, at first I didn't really wanted to, but since it seems that everyone think emojies that work is an important thing yes. |
New fixed version pushed. Pls could you merge with |
multibase.csv
Outdated
base64url, u, rfc4648 no padding, default | ||
base64urlpad, U, rfc4648 with padding, default | ||
proquint, p, PRO-QUINT https://arxiv.org/html/0901.4016, draft | ||
base256emoji, 🚀, base256 with custom alphabet using variable-sized-codepoints, draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know sorry (no I love that).
JuST GeT A PROper monO SPaCE FONt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I'm one space to short
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now actually monospace correct (if you had a monospace emoji it wouldn't break).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, got an implementation for this yet?
yes multiformats/go-multibase#46 |
multiformats/go-multibase#46 is now ready for review too. On my side it's RFM |
Merge commits really grind my gears .. but since you insist and there's recent precedent in this repo I'll hold my nose multiformats/js-multiformats#187 for JS impl |
I think this should be merged because :
TL;DR:
I think it has a very slight positive impact and no negative impact, let's merge this. :)