fix: add new emoji codepoint for Base256Emoji 🐉 #98
Conversation
|
Questions, none of the tests contain ☉ or 🌠, should I make a new one or can I rely on implementations getting this right ? |
1c4cb24 to
ae04ea4
Compare
|
/cc @vmx (you commented on the commit's thread) |
This include fixes for UTF-8 as well as base256emoji encoding (an encoding which actually use UTF-8).
|
Not a fan of the "backward compatibility" thing tbh, I think I'd prefer we just rip it out and get a fix into go-multibase as if it never existed the old way; we surely have permission to be a bit lose with a troll multibase. The JS impl hasn't been released and I'd lean to not even adding it there either way. |
ae04ea4 to
e75cd09
Compare
One of the values of base256emoji was not actually an emoji. Here there be dragons instead ! See multiformats/go-multibase@df5b7bc#r75683795 for context.
e75cd09 to
4c8344e
Compare
|
@rvagg I have removed it. It's now just breaking to 🐉 ! If anyone wants to do changes to the set (like propose your favorite emojies), pls do it now. I see that now that it's merged people are asking taking a look at it. Well we have to break it anyway, might as well bundle everything now. |
|
fine, let's do this (again) |
One of the values of base256emoji was not actually an emoji.
Here there be dragons instead !
See multiformats/go-multibase@df5b7bc#r75683795 for context.
Pls do not rebase (merge instead), I'm lazy and don't want to have to update the submodule once again.