Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UTF-8 and base256emoji #46

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Dec 4, 2021

Related: multiformats/multibase#88 (note it's not actually blocking because my last commit already update to the commit on my branch).

This include fixes for UTF-8 as well as base256emoji encoding (an encoding which actually use UTF-8).

If you want to know why I think this should be merged, see multiformats/multibase#88. :)

@BigLep
Copy link

BigLep commented Jan 7, 2022

2022-01-07: we're interested in including this because it shows we truly can support base 256 (and it's fun).

I left some comments on characters that aren't visible on macOS 12.0.1.

@rvagg : not a high priority at all, but do you have any concerns with this getting merged?

@BigLep BigLep requested a review from rvagg January 7, 2022 16:52
base256emoji.go Outdated Show resolved Hide resolved
base256emoji.go Outdated Show resolved Hide resolved
base256emoji.go Outdated Show resolved Hide resolved
@rvagg
Copy link
Member

rvagg commented Jan 10, 2022

This is fine by me, but it'd be good to get multiformats/multibase#88 sorted first, which Steven had some comments on re validity - which maybe should be coupled with the feedback here about FF availability - ensure we get the proper set included. Once we get it sorted maybe I'll try and put a version in js-multiformats too for fun.

@Jorropo
Copy link
Contributor Author

Jorropo commented Jun 8, 2022

Updated to the new charset which includes comments made.

The spec submodule was on a 2 year old commit and the tests structure 
changed, this bring it to the latest master at this time.
@Jorropo
Copy link
Contributor Author

Jorropo commented Jun 8, 2022

Note, in case multiformats/multibase#88 isn't merged with merge strategy (but with squash or rebase).
It is important to update the submodule.

@Jorropo Jorropo force-pushed the base256emoji branch 3 times, most recently from 924eccc to 202fdc2 Compare June 8, 2022 06:44
Jorropo added 2 commits June 8, 2022 08:56
This include fixes for UTF-8 as well as base256emoji encoding (an encoding which actually use UTF-8).
encoder.go Show resolved Hide resolved
Copy link

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of utf8 methods looks reasonable

@rvagg
Copy link
Member

rvagg commented Jun 9, 2022

thanks for the input Will

@rvagg rvagg merged commit 6e0e420 into multiformats:master Jun 9, 2022
@Jorropo Jorropo deleted the base256emoji branch June 9, 2022 05:30
Jorropo added a commit to Jorropo/go-ipfs that referenced this pull request Jun 9, 2022
This add supports for base256emoji.
multiformats/go-multibase#46
Jorropo added a commit to Jorropo/go-ipfs that referenced this pull request Jun 9, 2022
This add supports for base256emoji.
multiformats/go-multibase#46
Jorropo added a commit to Jorropo/go-ipfs that referenced this pull request Jun 9, 2022
This add supports for base256emoji.
multiformats/go-multibase#46
Jorropo added a commit to Jorropo/go-ipfs that referenced this pull request Jun 9, 2022
This add supports for base256emoji.
multiformats/go-multibase#46
Jorropo added a commit to Jorropo/go-ipfs that referenced this pull request Jun 9, 2022
This add supports for base256emoji.
multiformats/go-multibase#46
Jorropo added a commit to Jorropo/go-ipfs that referenced this pull request Jun 9, 2022
This add supports for base256emoji.
multiformats/go-multibase#46
Jorropo added a commit to Jorropo/go-ipfs that referenced this pull request Jun 9, 2022
This add supports for base256emoji.
multiformats/go-multibase#46
Jorropo added a commit to Jorropo/go-ipfs that referenced this pull request Jun 10, 2022
This add supports for base256emoji.
multiformats/go-multibase#46
Jorropo added a commit to Jorropo/go-ipfs that referenced this pull request Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants