Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update go-multibase 🚀 #9025

Merged
merged 1 commit into from
Jul 7, 2022
Merged

chore: update go-multibase 🚀 #9025

merged 1 commit into from
Jul 7, 2022

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jun 9, 2022 •
edited
Loading

This add supports for base256emoji. 🚀
multiformats/go-multibase#46

@Jorropo Jorropo added this to the go-ipfs 0.14 milestone Jun 9, 2022
@Jorropo Jorropo self-assigned this Jun 9, 2022
@Jorropo Jorropo force-pushed the emoji branch 6 times, most recently from c2bcabc to f589883 Compare June 10, 2022 17:05
@Jorropo Jorropo changed the title chore: update go-multibase chore: update go-multibase 🚀 Jun 11, 2022
@Stebalien
Copy link
Member

Please add a sharness test with an example emoji CID.

@Jorropo
Copy link
Contributor Author

Jorropo commented Jun 13, 2022

Update, blocked on: multiformats/go-multibase#52

@Jorropo Jorropo marked this pull request as draft June 13, 2022 19:17
@Jorropo Jorropo added the status/blocked Unable to be worked further until needs are met label Jun 14, 2022
@Jorropo Jorropo marked this pull request as ready for review July 7, 2022 19:52
@Jorropo Jorropo removed the status/blocked Unable to be worked further until needs are met label Jul 7, 2022
aschmahmann
aschmahmann requested changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sharness tests still broken, good to go once fixed though

@Jorropo Jorropo force-pushed the emoji branch 2 times, most recently from 7757749 to 2245de3 Compare July 7, 2022 20:07
@Jorropo Jorropo enabled auto-merge (rebase) July 7, 2022 20:08
aschmahmann
aschmahmann approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming CI is happy

@Jorropo Jorropo force-pushed the emoji branch 3 times, most recently from 422806d to 6b22e06 Compare July 7, 2022 21:11
lidel
lidel reviewed Jul 7, 2022
View reviewed changes
test/sharness/t0290-cid.sh Outdated Show resolved Hide resolved
@Jorropo
chore: update go-multibase 🚀
c20658a 
This add supports for base256emoji.
@Jorropo Jorropo merged commit cbb9aee into ipfs:master Jul 7, 2022
@Jorropo Jorropo deleted the emoji branch July 7, 2022 23:25
@Jorropo Jorropo restored the emoji branch December 12, 2022 22:32
@Jorropo Jorropo deleted the emoji branch December 12, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel left review comments

@aschmahmann aschmahmann aschmahmann approved these changes

Assignees

@Jorropo Jorropo

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
kubo 0.14
Development

Successfully merging this pull request may close these issues.
4 participants
@Jorropo @Stebalien @lidel @aschmahmann