Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable sdk-not-ready event #5185

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Disable sdk-not-ready event #5185

merged 3 commits into from
Oct 14, 2022

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Oct 14, 2022 •
edited
Loading

Fixes EXP-2852.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [ac: android-components-branch-name] and/or [fenix: fenix-branch-name] to the PR title.

@jhugman jhugman requested a review from travis79 October 14, 2022 13:32
@jhugman jhugman merged commit 835c456 into main Oct 14, 2022
@jhugman jhugman deleted the jhugman/exp-2852-disable-sdk-not-ready-events branch October 14, 2022 15:55
jhugman added a commit that referenced this pull request Oct 14, 2022
@jhugman
Disable sdk-not-ready-for-feature event (#5185) r=travis
538d03b 
* Disable sdk-not-ready event

* Add changelog

* Ignore test for disabled metrics
jhugman added a commit that referenced this pull request Oct 14, 2022
@jhugman
Disable sdk-not-ready-for-feature event (#5185) r=travis (#5186)
1e969ab 
* Disable sdk-not-ready event

* Add changelog

* Ignore test for disabled metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travis79 travis79 travis79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhugman @travis79