Disable sdk-not-ready-for-feature event (#5185) r=travis (#5186)

* Disable sdk-not-ready event * Add changelog * Ignore test for disabled metrics
mozilla · Oct 14, 2022 · 1e969ab · 1e969ab
1 parent 2b776cb
commit 1e969ab
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/CHANGES_UNRELEASED.md b/CHANGES_UNRELEASED.md
@@ -18,3 +18,8 @@ Use the template below to make assigning a version number during the release cut
   - Description of the change with a link to the pull request ([#0000](https://github.com/mozilla/application-services/pull/0000))
 
 -->
+
+## Nimbus ⛅️🔬🔭
+
+### What's Changed
+  - Disabled Glean events recorded when the SDK is not ready for a feature ([#5185](https://github.com/mozilla/application-services/pull/5185))
diff --git a/components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt b/components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt
@@ -25,6 +25,7 @@ import org.junit.Assert.assertNull
 import org.junit.Assert.assertTrue
 import org.junit.Assert.assertFalse
 import org.junit.Before
+import org.junit.Ignore
 import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -461,6 +462,7 @@ class NimbusTests {
     }
 
     @Test
+    @Ignore
     fun `in memory cache not ready logs an event`() {
         // we haven't initialized nimbus at all, it should not log any error, but it should log an
         // event

diff --git a/components/nimbus/metrics.yaml b/components/nimbus/metrics.yaml
@@ -125,9 +125,11 @@ nimbus_health:
       feature_id:
         type: string
         description: The feature id of the configuration that was requested
+    disabled: true
     bugs:
       - https://mozilla-hub.atlassian.net/browse/EXP-2689
       - https://mozilla-hub.atlassian.net/browse/EXP-2690
+      - https://mozilla-hub.atlassian.net/browse/EXP-2852
     data_reviews:
       - https://github.com/mozilla/application-services/pull/5091#issuecomment-1218359426
     data_sensitivity:
@@ -144,8 +146,10 @@ nimbus_health:
       feature_id:
         type: string
         description: The feature id of the configuration that was requested
+    disabled: true
     bugs:
       - https://mozilla-hub.atlassian.net/browse/EXP-2743
+      - https://mozilla-hub.atlassian.net/browse/EXP-2852
     data_reviews:
       - https://github.com/mozilla/application-services/pull/5118#issuecomment-1235827006
     data_sensitivity: