Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sdk-not-ready event #5185

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Disable sdk-not-ready event #5185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a00bbf2
Disable sdk-not-ready event
jhugman Oct 14, 2022
2ee0dde
Add changelog
jhugman Oct 14, 2022
7facbf1
Ignore test for disabled metrics
jhugman Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES_UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@ Use the template below to make assigning a version number during the release cut
- Description of the change with a link to the pull request ([#0000](https://github.com/mozilla/application-services/pull/0000))

-->

## Nimbus ⛅️🔬🔭

### What's Changed
- Disabled Glean events recorded when the SDK is not ready for a feature ([#5185](https://github.com/mozilla/application-services/pull/5185))
2 changes: 2 additions & 0 deletions components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import org.junit.Assert.assertNull
import org.junit.Assert.assertTrue
import org.junit.Assert.assertFalse
import org.junit.Before
import org.junit.Ignore
import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
Expand Down Expand Up @@ -461,6 +462,7 @@ class NimbusTests {
}

@Test
@Ignore
fun `in memory cache not ready logs an event`() {
// we haven't initialized nimbus at all, it should not log any error, but it should log an
// event
Expand Down
4 changes: 4 additions & 0 deletions components/nimbus/metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,11 @@ nimbus_health:
feature_id:
type: string
description: The feature id of the configuration that was requested
disabled: true
bugs:
- https://mozilla-hub.atlassian.net/browse/EXP-2689
- https://mozilla-hub.atlassian.net/browse/EXP-2690
- https://mozilla-hub.atlassian.net/browse/EXP-2852
data_reviews:
- https://github.com/mozilla/application-services/pull/5091#issuecomment-1218359426
data_sensitivity:
Expand All @@ -144,8 +146,10 @@ nimbus_health:
feature_id:
type: string
description: The feature id of the configuration that was requested
disabled: true
bugs:
- https://mozilla-hub.atlassian.net/browse/EXP-2743
- https://mozilla-hub.atlassian.net/browse/EXP-2852
data_reviews:
- https://github.com/mozilla/application-services/pull/5118#issuecomment-1235827006
data_sensitivity:
Expand Down