Add warnings to pr and v #116
Conversation
faefea9 to
4832813
Compare
6f6d568 to
cad6d1f
Compare
packages/cmcd-validator-library/src/keyValueValidator/keysValueValidator.js
Outdated
Show resolved
Hide resolved
packages/cmcd-validator-library/src/keyValueValidator/validatorFunctions.js
Outdated
Show resolved
Hide resolved
5548216 to
b1a4dab
Compare
b1a4dab to
fd3bd9a
Compare
| warnings: [ | ||
| { | ||
| type: 'pr-value', | ||
| key: 'pr', | ||
| value: 1, | ||
| description: 'SHOULD only be sent if not equal to 1.' | ||
| } | ||
| ], |
There was a problem hiding this comment.
Why do we have this warning? The input is
https://dash.akamaized.net/akamai/bbb_30fps/bbb_a64k/bbb_a64k_7.m4a?CMCD=bl%3D21300%2Cbr%3D3200%2Cbs%2Ccid%3D%22faec5fc2-ac30-11ea-bb37-0242ac130002%22%2Cd%3D4004%2Cdl%3D18500%2Cmtp%3D48100%2Cnor%3D%22%252F300kbps%252Ftrack.m4v%22%2Cnrr%3D%2212323-48763%22%2Cot%3Dv%2Cpr%3D1.08%2Crtp%3D12000%2Csf%3Dd%2Csid%3D%226e2fb550-c457-11e9-bb97-0800200c9a66%22%2Cst%3Dv%2Csu%2Ctb%3D6000
If you check the query pr=1.08
| warnings: [ | ||
| { | ||
| type: 'pr-value', | ||
| key: 'pr', | ||
| value: 1, | ||
| description: 'SHOULD only be sent if not equal to 1.' | ||
| } | ||
| ], |
There was a problem hiding this comment.
Here is the same as above. pr = 1.08
There was a problem hiding this comment.
I think there's something wrong here. In the queries pr=1.08 and we have the warning SHOULD only be sent if not equal to 1.
Another thing to consider is the there's something wrong in the parser because if you see pr=1
There was a problem hiding this comment.
This ticket #119 has been created to solve this bug
| @@ -70,12 +70,16 @@ export const cmcdHeader = { | |||
|
|
|||
| export const warningTypes = { | |||
| noAlphabeticalOrder: 'no-alphabetical-order', | |||
| valuePR: 'pr-value', | |||
There was a problem hiding this comment.
I would change valuePR to valuePr
| noSidReceived: 'no-sid-received', | ||
| blWithWrongOtValue: 'bl-with-wrong-ot-value', | ||
| }; | ||
|
|
||
| export const warningDescription = { | ||
| noAlphabeticalOrder: 'Keys are not arranged alphabetically', | ||
| valuePR: 'SHOULD only be sent if not equal to 1.', |
There was a problem hiding this comment.
I would change SHOULD only be sent if not equal to 1 to pr should only be sent if not equal to 1
| noSidReceived: 'no-sid-received', | ||
| blWithWrongOtValue: 'bl-with-wrong-ot-value', | ||
| }; | ||
|
|
||
| export const warningDescription = { | ||
| noAlphabeticalOrder: 'Keys are not arranged alphabetically', | ||
| valuePR: 'SHOULD only be sent if not equal to 1.', | ||
| valueV: 'Client SHOULD omit this field if the version is 1', |
There was a problem hiding this comment.
I would change 'Client SHOULD omit this field if the version is 1' to 'Client should omit this field if the version is 1'
No description provided.