New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M1.5: Fix PR bug in parser #119

Open

rodrigo-mira opened this issue Mar 15, 2023 · 0 comments

Assignees

Labels

bug

Milestone

M1.5: Update libr...

Contributor

rodrigo-mira commented Mar 15, 2023

{
description: 'Test: Correct query check nrr start-end',
query:
'https://dash.akamaized.net/akamai/bbb_30fps/bbb_a64k/bbb_a64k_7.m4a?CMCD=bl%3D21300%2Cbr%3D3200%2Cbs%2Ccid%3D%22faec5fc2-ac30-11ea-bb37-0242ac130002%22%2Cd%3D4004%2Cdl%3D18500%2Cmtp%3D48100%2Cnor%3D%22%252F300kbps%252Ftrack.m4v%22%2Cnrr%3D%2212323-48763%22%2Cot%3Dv%2Cpr%3D1.08%2Crtp%3D12000%2Csf%3Dd%2Csid%3D%226e2fb550-c457-11e9-bb97-0800200c9a66%22%2Cst%3Dv%2Csu%2Ctb%3D6000',
output: {
valid: true,
errors: [],
warnings: [
{
type: 'pr-value',
key: 'pr',
value: 1,
description: 'SHOULD only be sent if not equal to 1.'
}
],
parsedData: {
bl: 21300,
br: 3200,
bs: true,
cid: 'faec5fc2-ac30-11ea-bb37-0242ac130002',
d: 4004,
dl: 18500,
mtp: 48100,
nor: '%2F300kbps%2Ftrack.m4v',
nrr: '12323-48763',
ot: 'v',
pr: 1,
rtp: 12000,
sf: 'd',
sid: '6e2fb550-c457-11e9-bb97-0800200c9a66',
st: 'v',
su: true,
tb: 6000,
},
rawData: 'https://dash.akamaized.net/akamai/bbb_30fps/bbb_a64k/bbb_a64k_7.m4a?CMCD=bl%3D21300%2Cbr%3D3200%2Cbs%2Ccid%3D%22faec5fc2-ac30-11ea-bb37-0242ac130002%22%2Cd%3D4004%2Cdl%3D18500%2Cmtp%3D48100%2Cnor%3D%22%252F300kbps%252Ftrack.m4v%22%2Cnrr%3D%2212323-48763%22%2Cot%3Dv%2Cpr%3D1.08%2Crtp%3D12000%2Csf%3Dd%2Csid%3D%226e2fb550-c457-11e9-bb97-0800200c9a66%22%2Cst%3Dv%2Csu%2Ctb%3D6000',
},
}

As in the example shows, the PR field in the query is 1.08 but in the parsedData pr value is 1.

rodrigo-mira added this to CMCD Validator & Analyzer

rodrigo-mira converted this from a draft issue

rodrigo-mira added the bug label

rodrigo-mira added this to the M1.5: Update library to be more robust milestone

rodrigo-mira changed the title ~~M1.5: Fix PR bug~~ M1.5: Fix PR bug in parser

CamiloBorba09 mentioned this issue

Add warnings to pr and v #116

Merged

adriansqualabs self-assigned this

adriansqualabs moved this from 📋 Backlog to ✅ Done in CMCD Validator & Analyzer

JoaquinBCh moved this from ✅ Done to ✅ Done old in CMCD Validator & Analyzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment