suggested changes

montevideo-tech · Mar 15, 2023 · b1a4dab · b1a4dab
1 parent cad6d1f
commit b1a4dab
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 30 deletions.
diff --git a/packages/cmcd-validator-library/src/keyValueValidator/keysValueValidator.js b/packages/cmcd-validator-library/src/keyValueValidator/keysValueValidator.js
@@ -1,7 +1,7 @@
 import {
   checkMaxLength, isEncoded, checkValidNrrFormat, checkRoundToNearest, checkIgnoredParameter,
   isReserved, isPositive, checkBlKey, checkCorrectType, checkOtValidValue, checkSfValidValue,
-  checkPRValue,
+  checkPrValue,
   checkVValue,
   checkStValidValue, checkSidIsPresent,
 } from './validatorFunctions.js';
@@ -61,7 +61,7 @@ const keyValValidator = (cmcdJson, errors, warnings, warningFlag = true) => {
         break;
       case 'pr':
         if(warningFlag) {
-          checkPRValue(cmcdJson, warnings, key, keyValue);
+          checkPrValue(cmcdJson, warnings, key, keyValue);
         }
         break;
       case 'v':

diff --git a/packages/cmcd-validator-library/src/keyValueValidator/validatorFunctions.js b/packages/cmcd-validator-library/src/keyValueValidator/validatorFunctions.js
@@ -89,8 +89,8 @@ export const checkStValidValue = (errors, key, value) => {
   checkValidValue(errors, key, value, ['v', 'l']);
 };
 
-export const checkPRValue = (cmcdJson, warnings, key, value) => {
-  if ((key === 'pr') && value === 1) {
+export const checkPrValue = (cmcdJson, warnings, key, value) => {
+  if (key === 'pr' && value === 1) {
     warnings.push(createWarning(warningTypes.valuePR, key, value));
   }
 };

diff --git a/packages/cmcd-validator-library/src/tests/testCases/jsonTestCases.js b/packages/cmcd-validator-library/src/tests/testCases/jsonTestCases.js
@@ -1303,7 +1303,7 @@ export const jsonTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
        ],
        parsedData: {

diff --git a/packages/cmcd-validator-library/src/tests/testCases/queryTestCases.js b/packages/cmcd-validator-library/src/tests/testCases/queryTestCases.js
@@ -380,7 +380,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -417,7 +417,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -454,7 +454,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -498,7 +498,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -535,7 +535,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -572,7 +572,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -609,7 +609,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -652,7 +652,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -697,7 +697,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -742,7 +742,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -786,7 +786,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         },
       ],
       parsedData: {
@@ -831,7 +831,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -883,7 +883,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -927,7 +927,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -971,7 +971,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -1050,7 +1050,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -1088,7 +1088,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -1126,7 +1126,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -1164,7 +1164,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -1209,7 +1209,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -1247,7 +1247,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -1285,7 +1285,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -1331,7 +1331,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {
@@ -1442,7 +1442,7 @@ export const queryTestCases = [
           type: 'pr-value',
           key: 'pr',
           value: 1,
-          description: 'SHOULD only be sent if not equal to 1.'
+          description: 'SHOULD only be sent if not equal to 1.xx'
         }
       ],
       parsedData: {

diff --git a/packages/cmcd-validator-library/src/utils/constants.js b/packages/cmcd-validator-library/src/utils/constants.js
@@ -78,7 +78,7 @@ export const warningTypes = {
 
 export const warningDescription = {
   noAlphabeticalOrder: 'Keys are not arranged alphabetically',
-  valuePR: 'SHOULD only be sent if not equal to 1.',
+  valuePR: 'SHOULD only be sent if not equal to 1.xx',
   valueV: 'Client SHOULD omit this field if the version is 1',
   noSidReceived: 'No sid received from CMCD message',
   blWithWrongOtValue: 'bl key should only be sent with an object type of a, v or av',