Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parametric model from survivalmodels #345

Merged
merged 8 commits into from
Mar 13, 2024
Merged

add parametric model from survivalmodels #345

merged 8 commits into from
Mar 13, 2024

Conversation

bblodfon
Copy link
Collaborator

@bblodfon bblodfon commented Mar 8, 2024

Solves #41

@bblodfon bblodfon requested review from RaphaelS1 and sebffischer and removed request for RaphaelS1 March 8, 2024 18:25
sebffischer
sebffischer requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@sebffischer sebffischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please first fix the issues in the CI, then I can look at it :)
Lmk if you have any specific questions

sebffischer
sebffischer approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@sebffischer sebffischer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯 Only one suggestion for a refactor, but not needed :) let me know if I should merge.

The failing CI is caused by mlr3cluster and will resolve itself eventually.

R/learner_survival_surv_parametric.R
#'
#' `lp` is predicted using the formula \eqn{lp = X\beta} where \eqn{X} are the variables in the test
#' data set and \eqn{\beta} are the fitted coefficients.
#' Three types of prediction are returned for this learner:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to generate this programmatically, i.e. something like r surv_predict_types("lp", "crank")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea. Since I plan to go through all survival learners and chnage the prediction order (#331), I can see how many need that prediction info and refactor it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #347

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or better a doc template?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both is fine, whatever works :)

@bblodfon
Copy link
Collaborator Author

@sebffischer good to merge now, just fixed some minor styling issues.

@sebffischer sebffischer merged commit 5e291e0 into main Mar 13, 2024
4 of 5 checks passed
@sebffischer sebffischer deleted the parametric branch March 13, 2024 09:36
@bblodfon bblodfon mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebffischer sebffischer sebffischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bblodfon @sebffischer