Skip to content

Commit

Permalink
add parametric model from survivalmodels (#345)
Browse files Browse the repository at this point in the history
* add implementation of parametric from survivalmodels

* fix param test

* small fixes, better doc, rename 'type' parameter to 'form'

* update parametric learner tests

* update NEWS.md

* update doc

* fix styling

* fix another styling issue
  • Loading branch information
bblodfon authored Mar 13, 2024
1 parent 5baa86a commit 5e291e0
Show file tree
Hide file tree
Showing 6 changed files with 188 additions and 380 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ Suggests:
sm,
stats,
survival,
survivalmodels,
survivalmodels (>= 0.1.19),
survivalsvm,
tensorflow (>= 2.0.0),
testthat,
Expand All @@ -122,5 +122,5 @@ Config/testthat/edition: 3
Encoding: UTF-8
NeedsCompilation: no
Roxygen: list(markdown = TRUE, r6 = TRUE)
RoxygenNote: 7.2.3.9000
RoxygenNote: 7.3.1.9000
Config/Needs/website: rmarkdown
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# mlr3extralearners 0.7.1-9000

* Ported `surv.parametric` code to `survivalmodels`, changed `type` parameter to `form` to avoid conflict with survivalmodels's default parameter list
* Fix: Replace hardcoded `VectorDistribution`s from partykit and flexsurv survival learners with survival matrices (`Matdist`) (thanks to @bblodfon)
* Feat: Add `discrete` parameter in `surv.parametric` learner to return `Matdist` survival predictions
* Added method `selected_features()` to CoxBoost survival learners (thanks to @bblodfon)
Expand Down
Loading

0 comments on commit 5e291e0

Please sign in to comment.