Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parametric model from survivalmodels #345

Merged
merged 8 commits into from
Mar 13, 2024
Merged

add parametric model from survivalmodels #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b966639
add implementation of parametric from survivalmodels
bblodfon Mar 8, 2024
0cc74c8
fix param test
bblodfon Mar 8, 2024
0612dbb
small fixes, better doc, rename 'type' parameter to 'form'
bblodfon Mar 11, 2024
d0e1f33
update parametric learner tests
bblodfon Mar 11, 2024
9bc0246
update NEWS.md
bblodfon Mar 11, 2024
af5df54
update doc
bblodfon Mar 11, 2024
f037b60
fix styling
bblodfon Mar 13, 2024
83c9334
fix another styling issue
bblodfon Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ Suggests:
sm,
stats,
survival,
survivalmodels,
survivalmodels (>= 0.1.19),
survivalsvm,
tensorflow (>= 2.0.0),
testthat,
Expand All @@ -122,5 +122,5 @@ Config/testthat/edition: 3
Encoding: UTF-8
NeedsCompilation: no
Roxygen: list(markdown = TRUE, r6 = TRUE)
RoxygenNote: 7.2.3.9000
RoxygenNote: 7.3.1.9000
Config/Needs/website: rmarkdown
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# mlr3extralearners 0.7.1-9000

* Ported `surv.parametric` code to `survivalmodels`, changed `type` parameter to `form` to avoid conflict with survivalmodels's default parameter list
* Fix: Replace hardcoded `VectorDistribution`s from partykit and flexsurv survival learners with survival matrices (`Matdist`) (thanks to @bblodfon)
* Feat: Add `discrete` parameter in `surv.parametric` learner to return `Matdist` survival predictions
* Added method `selected_features()` to CoxBoost survival learners (thanks to @bblodfon)
Expand Down
Loading
Loading