Fix [_1,_2,_3] parameters (conflict with Ruby 2.7.0); Updated gems and ruby versions. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jasnow
commented
Dec 26, 2019
- Fix [_1,_2,_3] parameters as they are numbered parameters in Ruby 2.7.0.
- Updated gems and ruby versions in .travis.yml file.
- Add 2.7.0 to .travis.yml file.
- Removed 2.1.0 from .travis.yml file.
halostatue
requested changes
Dec 26, 2019
halostatue
approved these changes
Dec 26, 2019
|
@halostatue - You are welcome to change my changes before releasing them if you wish. Happy Holidays.... |
|
Bumped into this this morning. Was going to create a PR and saw @jasnow was already on top of it. Thank you! |
|
U R Welcome |
|
Thanks for your contribution! mime-types 3.3 was released in September, so this will be version 3.3.1. |
|
Verified in release 3.3.1 of gem. |
This was referenced Apr 23, 2021
tnir
added a commit
to tnir/rails_sample_app
that referenced
this pull request
May 19, 2021
See mime-types/ruby-mime-types#146 Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
lfdebrux
added a commit
to alphagov/seal
that referenced
this pull request
Jun 16, 2021
Bumps [mime-types](https://github.com/mime-types/ruby-mime-types) from 3.2.2 to 3.3.1: - [Changelog](https://github.com/mime-types/ruby-mime-types/blob/master/History.md) - [Commits](mime-types/ruby-mime-types@v3.2.2...v3.3.1) --- Updated to include [mime-types/ruby-mimetypes#176](mime-types/ruby-mime-types#146) which silences the warnings about `MIME::Types::Logger`: ``` ./seal/.bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_1' is reserved for numbered parameter; consider another name ./seal/.bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_2' is reserved for numbered parameter; consider another name ./seal/.bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_3' is reserved for numbered parameter; consider another name ``` Used `bundle update mime-types` to do the bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.