Unlock mime-type gem version to support Ruby 3 #1124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request addresses these syntax errors which has been fixed by mime-types/ruby-mime-types#146 ```ruby $ ruby -v ruby 3.0.0dev (2020-10-24T13:53:53Z master 148961adcd) [x86_64-linux] $ bundle exec rake spec An error occurred while loading ./spec/delayed/command_spec.rb. Failure/Error: require 'coveralls' SyntaxError: /home/yahonda/.rbenv/versions/3.0.0-dev/lib/ruby/gems/3.0.0/gems/mime-types-2.6.2/lib/mime/types/logger.rb:26: _1 is reserved for numbered parameter /home/yahonda/.rbenv/versions/3.0.0-dev/lib/ruby/gems/3.0.0/gems/mime-types-2.6.2/lib/mime/types/logger.rb:26: _2 is reserved for numbered parameter /home/yahonda/.rbenv/versions/3.0.0-dev/lib/ruby/gems/3.0.0/gems/mime-types-2.6.2/lib/mime/types/logger.rb:26: _3 is reserved for numbered parameter /home/yahonda/.rbenv/versions/3.0.0-dev/lib/ruby/gems/3.0.0/gems/mime-types-2.6.2/lib/mime/types/columnar.rb:16: warning: already initialized constant MIME::Types::Columnar::LOAD_MUTEX /home/yahonda/.rbenv/versions/3.0.0-dev/lib/ruby/gems/3.0.0/gems/mime-types-2.6.2/lib/mime/types/columnar.rb:16: warning: previous definition of LOAD_MUTEX was here ```
|
I think you have something odd on your system. That gem line is for jruby not MRI. It would not apply to MRI ruby 3.0. Nothing in delayed job's gemfile for MRI ruby pulls in mime-types. |
|
Thanks for the comment. It does not reproduce anymore. I might be doing something wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses these syntax errors which has been fixed by mime-types/ruby-mime-types#146