Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mime-types from 3.2.2 to 3.3.1 #232

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Bump mime-types from 3.2.2 to 3.3.1 #232

merged 1 commit into from
Aug 2, 2021

Conversation

lfdebrux
Copy link
Member

Bumps mime-types from 3.2.2 to 3.3.1:


Updated to include
mime-types/ruby-mimetypes#176
which silences the warnings about MIME::Types::Logger:

./seal/.bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_1' is reserved for numbered parameter; consider another name
./seal/.bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_2' is reserved for numbered parameter; consider another name
./seal/.bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_3' is reserved for numbered parameter; consider another name

Used bundle update mime-types to do the bump.

Bumps [mime-types](https://github.com/mime-types/ruby-mime-types) from 3.2.2 to 3.3.1:
  - [Changelog](https://github.com/mime-types/ruby-mime-types/blob/master/History.md)
  - [Commits](mime-types/ruby-mime-types@v3.2.2...v3.3.1)

---

Updated to include
[mime-types/ruby-mimetypes#176](mime-types/ruby-mime-types#146)
which silences the warnings about `MIME::Types::Logger`:

```
./seal/.bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_1' is reserved for numbered parameter; consider another name
./seal/.bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_2' is reserved for numbered parameter; consider another name
./seal/.bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_3' is reserved for numbered parameter; consider another name
```

Used `bundle update mime-types` to do the bump.
Copy link
Contributor

@cbaines cbaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

@lfdebrux lfdebrux merged commit d0ee45e into main Aug 2, 2021
@lfdebrux lfdebrux deleted the ldeb-bump-mime-types branch August 2, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants