Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit settings for language should preserve settings search input #145711

Closed
isidorn opened this issue Mar 22, 2022 · 3 comments · Fixed by #147727
Closed

Edit settings for language should preserve settings search input #145711

isidorn opened this issue Mar 22, 2022 · 3 comments · Fixed by #147727
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 22, 2022

Testing #145588

  1. Open settings ui. Type editor.wordwrap
  2. Click on the "Edit settings for markdown" button
  3. Search is now @lang:markdown
  4. It should be @lang:markdown editor.wordwrap. Thus my input should be preserved

fyi @sandy081

@isidorn isidorn added the settings-editor VS Code settings editor issues label Mar 22, 2022
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Apr 13, 2022
@rzhao271 rzhao271 added this to the April 2022 milestone Apr 13, 2022
@rzhao271 rzhao271 added the confirmed Issue has been confirmed by VS Code Team member label Apr 15, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Apr 15, 2022

For step 2, I assume you ran the workbench.action.configureLanguageBasedSettings command and then selected "markdown" from the quickpick?

Also, if I type a query into the Settings editor, then switch to a different tab, and then run that command and select a language, it will focus back into the Settings editor. But, at that point, I'm not sure whether we should preserve the old query or replace it completely. I also assume this is the more common use case, because we now have a funnel button in the Settings editor search widget that one can use to append a language filter to the query.

@rzhao271 rzhao271 added the info-needed Issue requires more information from poster label Apr 15, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Apr 19, 2022

No, for step 2 I clicked on the following button / link

Screenshot 2022-04-19 at 15 29 38

@rzhao271
Copy link
Contributor

Verification steps: #145711 (comment)
Also see #145711 (comment)

I also confirmed that the markdown setting shows up there in the first place because an extension has contributed a markdown-specific default override for the editor.wordwrap setting. After clicking on the "Edit settings for markdown" link, we currently don't show the default override indicator, which is a known issue that is being tracked separately.

@isidorn isidorn added the verified Verification succeeded label Apr 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@isidorn @rzhao271 and others