Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Language-specific settings filter in the Settings editor #145588

Closed
2 tasks done
rzhao271 opened this issue Mar 21, 2022 · 0 comments
Closed
2 tasks done

Test: Language-specific settings filter in the Settings editor #145588

rzhao271 opened this issue Mar 21, 2022 · 0 comments

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Mar 21, 2022

Refs: #131707

Complexity: 4

Create Issue


We now support a language filter in the Settings editor. This filter allows one to view and modify language-specific settings.

  1. Navigate to the Settings editor.
  2. Type a language filter such as @lang:css into the search widget.
  3. All language-overridable settings should show up.
  4. Let's say you're in the User tab with the @lang:css filter. The setting value that should show up for a simple setting such as editor.tabSize is as follows:
    • If you set a language-specific value in the user settings file for that setting, that value should be rendered.
    • Otherwise, if an extension you have or wrote contributes a default language-specific value for that setting, that value should be rendered. You can hit this case by writing/modifying an extension that adds on a configurationDefaults object within the contributes section, where within the configurationDefaults object, you add an object with a key such as [css] to represent the language-specific default values. An example is at https://github.com/microsoft/vscode/blob/main/extensions/css-language-features/package.json#L901.
    • Otherwise, if there is a plain user settings value for that setting, that value should be rendered.
    • Otherwise, the default value of that setting should be rendered.
  5. In the workspace tab, the value that should show up is similar to point 4 above, though the precedence order would be language-specific workspace value > language-specific default value > workspace value > default value.
  6. Verify that for language-specific values, one must manually reset the value in order for the language override value to disappear from the settings json file.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants