Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language filter placement, fixes #145711 #147727

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Apr 19, 2022

This PR fixes #145711

  1. Search for a query such that a language config setting such as markdown shows up (the description of that setting will read "Configure settings to be overridden for the markdown language.") Two search queries that help with this step are editor.wordwrap and markdown (both case-sensitive).
  2. For the markdown query, when pressing on the "Edit settings for markdown" link, the search query should become @lang:markdown.
  3. For the editor.wordwrap query, when pressing on the "Edit settings for markdown" link, the search query should become editor.wordwrap @lang:markdown.

@rzhao271 rzhao271 added this to the April 2022 milestone Apr 19, 2022
@rzhao271 rzhao271 requested a review from roblourens April 19, 2022 22:02
@rzhao271 rzhao271 self-assigned this Apr 19, 2022
@rzhao271 rzhao271 requested a review from roblourens April 20, 2022 17:34
@rzhao271 rzhao271 requested a review from roblourens April 20, 2022 18:23
@rzhao271 rzhao271 merged commit f171e5e into main Apr 20, 2022
@rzhao271 rzhao271 deleted the rzhao271/language-modify-polish branch April 20, 2022 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit settings for language should preserve settings search input
2 participants