suppressApplicationTitle will suppress initial application title #3837
Conversation
There was a problem hiding this comment.
One last thing -- and this might actually fix the Azure Cloud Shell issue (!) -- is that you could set the _title to be _startingTitle if _suppressApplicationTitle is enabled in the Terminal::CreateFromSettings function. If you do that, it will get set to the correct value on creation!
Done! |
| if (_suppressApplicationTitle) | ||
| { | ||
| _title = _startingTitle; | ||
| } |
There was a problem hiding this comment.
er, this is not in the right place and will never trigger 😦
It needs to be after line 98, UpdateSettings, because these values are never being set to anything otherwise..
There was a problem hiding this comment.
...oops...I should not have merged that huh... Sorry!
There was a problem hiding this comment.
I shouldn't have Approved with pending "please write new code" comments 😄
Fixed bug where suppressApplicationTitle didn't suppress initial title from application Also fixes the Azure Cloud Shell issue. (cherry picked from commit 54966c3)
|
🎉 Handy links: |
Summary of the Pull Request
Fixed bug where suppressApplicationTitle didn't suppress initial title from application
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed