Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suppressApplicationTitle PR #3837 #3859

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Fix suppressApplicationTitle PR #3837 #3859

merged 1 commit into from
Dec 6, 2019

Conversation

cinnamon-msft
Copy link
Contributor

Summary of the Pull Request

I moved the code snip down to trigger properly.

References

PR Checklist

  • Closes Followup from suppressApplicationTitle PR #3837 #3839
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@cinnamon-msft cinnamon-msft requested a review from a team December 6, 2019 00:44
@cinnamon-msft cinnamon-msft merged commit 2354965 into master Dec 6, 2019
@cinnamon-msft cinnamon-msft deleted the cinnamon/3839-suppress-app-title-fix branch December 6, 2019 17:50
DHowett-MSFT pushed a commit that referenced this pull request Dec 11, 2019
@cinnamon-msft @DHowett
Fix suppressApplicationTitle PR #3837 (#3859)
8f0bd3c 
(cherry picked from commit 2354965)
@ghost
Copy link

ghost commented Dec 12, 2019

🎉Windows Terminal Preview v0.7.3451.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Dec 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rofi93 rofi93 rofi93 approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Followup from suppressApplicationTitle PR #3837
4 participants
@cinnamon-msft @rofi93 @carlos-zamora @DHowett-MSFT