Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppressApplicationTitle will suppress initial application title #3837

Merged
merged 3 commits into from
Dec 4, 2019
+7 −18
Merged

suppressApplicationTitle will suppress initial application title #3837

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3b7fdf
fixed bug and simplified title setting function
cinnamon-msft Dec 4, 2019
fa2f251
code cleanup
cinnamon-msft Dec 4, 2019
eacf50f
checked for suppress app title in createFromSettings
cinnamon-msft Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions src/cascadia/TerminalCore/TerminalApi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,25 +365,9 @@ bool Terminal::EraseInDisplay(const DispatchTypes::EraseType eraseType)

bool Terminal::SetWindowTitle(std::wstring_view title)
{
// Set the title on Terminal load
if (_title.empty())
{
_title = title;
_pfnTitleChanged(title);
}

_title = title;

// If this is removed, the tab object assumes the application title is the title
if (_suppressApplicationTitle)
{
_title = _startingTitle;
}
_title = _suppressApplicationTitle ? _startingTitle : title;

if (_pfnTitleChanged && !_suppressApplicationTitle)
{
_pfnTitleChanged(_title);
}
_pfnTitleChanged(_title);

return true;
}
Expand Down