Fix props validation for Breadcrumb #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b450575 to
61224e6
Compare
lambertwang-zz
approved these changes
Apr 25, 2018
JasonGore
reviewed
Apr 25, 2018
| @@ -204,7 +204,7 @@ export class Breadcrumb extends BaseComponent<IBreadcrumbProps, any> { | |||
| */ | |||
| private _validateProps(props: IBreadcrumbProps): void { | |||
| const { items, overflowIndex } = props; | |||
| if (overflowIndex! < 0 || overflowIndex! > items.length - 1) { | |||
| if (overflowIndex! < 0 || overflowIndex! > items.length) { | |||
There was a problem hiding this comment.
This fixes the issue when items is of 0 length. However, if items is of length N and overflowIndex is also N, I think this new change will now consider that a valid scenario when it isn't. I wonder if instead overflowIndex should only be compared against items.length when items.length is > 0 (leaving the original items.length - 1 change in.)
There was a problem hiding this comment.
(I guess some expect error test cases would be useful here too.)
JasonGore
requested changes
Apr 25, 2018
61224e6 to
45c7a49
Compare
JasonGore
reviewed
Apr 25, 2018
| if (overflowIndex! < 0 || overflowIndex! > items.length - 1) { | ||
| const { maxDisplayedItems, overflowIndex, items } = props; | ||
| if (overflowIndex! < 0 || | ||
| maxDisplayedItems! > 1 && overflowIndex! > maxDisplayedItems! - 1 || |
There was a problem hiding this comment.
Should overflowIndex be compared against maxDisplayedItems when maxDisplayedItems is 1?
There was a problem hiding this comment.
I think this is enough sanity checking for the moment. The component doesn't actually break if you specify values out-of-bounds.
JasonGore
approved these changes
Apr 25, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Apr 26, 2018
* master: (42 commits) Applying package updates. ProgressIndicator: Finish conversion to mergeStyles (microsoft#4595) Fix props validation for Breadcrumb (microsoft#4666) No unused vars part of ts (microsoft#4670) Picker/Autofill: fixes several minor bugs. (microsoft#4569) Fix Calendar component PREV/NEXT month, year, and "Go to today" handlers firing twice (microsoft#4662) Applying package updates. Merge styles order (microsoft#4664) Fabric component: revert class change and make it backwards compatible (microsoft#4671) Addressing Issue microsoft#3707 - OverflowSet: Add the ability to set aria-label (microsoft#4667) Fix input type for Tile ARIA label prop (microsoft#4668) Fix theme slots for DetailsList header colors (microsoft#4658) Applying package updates. Jolore/calendar updates (microsoft#4643) Remove wordWrap setting. (microsoft#4657) Pivot: convert to mergeStyles - part 1 (microsoft#4656) Use the `data-is-scrollable` attribute on the correct ScrollablePane div (microsoft#4602) Applying package updates. Remove unused iconClassName prop from Nav.types (microsoft#4634) Jest snapshots: classes in animations should autoexpand. (microsoft#4647) ...
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Apr 26, 2018
* master: (34 commits) Applying package updates. ProgressIndicator: Finish conversion to mergeStyles (microsoft#4595) Fix props validation for Breadcrumb (microsoft#4666) No unused vars part of ts (microsoft#4670) Picker/Autofill: fixes several minor bugs. (microsoft#4569) Fix Calendar component PREV/NEXT month, year, and "Go to today" handlers firing twice (microsoft#4662) Applying package updates. Merge styles order (microsoft#4664) Fabric component: revert class change and make it backwards compatible (microsoft#4671) Addressing Issue microsoft#3707 - OverflowSet: Add the ability to set aria-label (microsoft#4667) Fix input type for Tile ARIA label prop (microsoft#4668) Fix theme slots for DetailsList header colors (microsoft#4658) Applying package updates. Jolore/calendar updates (microsoft#4643) Remove wordWrap setting. (microsoft#4657) Pivot: convert to mergeStyles - part 1 (microsoft#4656) Use the `data-is-scrollable` attribute on the correct ScrollablePane div (microsoft#4602) Applying package updates. Remove unused iconClassName prop from Nav.types (microsoft#4634) Jest snapshots: classes in animations should autoexpand. (microsoft#4647) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change is to address bug #4663:
itemsis[]).items.lengthis0, and also added validation againstmaxDisplayedItems, since that impacts overflow behavior, too.