ProgressIndicator: Finish conversion to mergeStyles #4595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 17, 2018 16:33
|
@dzearing I'm getting weird behavior with mergeStyles injecting tons of How do I prevent
|
dzearing
reviewed
Apr 19, 2018
| className: this.props.className, | ||
| barHeight: this.props.barHeight, | ||
| indeterminate: this.props.percentComplete === undefined ? true : false, | ||
| }); |
There was a problem hiding this comment.
caching this in the constructor means if classname or barheight change after render, we wouldn't update.
dzearing
reviewed
Apr 19, 2018
| { | ||
| position: 'relative', | ||
| overflow: 'hidden', | ||
| height: `${barHeight}px`, |
There was a problem hiding this comment.
nit, this can just be barHeight
There was a problem hiding this comment.
Scan for similar px based things.
dzearing
reviewed
Apr 19, 2018
| { | ||
| position: 'absolute', | ||
| minWidth: '33%', | ||
| background: `linear-gradient(to right, transparent 0%, ${palette.themePrimary} 50%, transparent 100%)`, |
There was a problem hiding this comment.
this may not work in RTL. I'm not sure we will flip "to right" in the linear-gradient... Test in RTL, workaround is (getRTL() ? 'left': 'right')
There was a problem hiding this comment.
The gradient is symmetrical so it doesn't currently make a difference between to right or to left, but if it were to change it'd be nice to flip.
|
ugh. Looks like animation class names aren't getting expanded. Let me see if I can fix that in the serializer! |
|
@dzearing Are we good to merge this now? |
oengusmacinog-zz
approved these changes
Apr 25, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Apr 26, 2018
* master: (42 commits) Applying package updates. ProgressIndicator: Finish conversion to mergeStyles (microsoft#4595) Fix props validation for Breadcrumb (microsoft#4666) No unused vars part of ts (microsoft#4670) Picker/Autofill: fixes several minor bugs. (microsoft#4569) Fix Calendar component PREV/NEXT month, year, and "Go to today" handlers firing twice (microsoft#4662) Applying package updates. Merge styles order (microsoft#4664) Fabric component: revert class change and make it backwards compatible (microsoft#4671) Addressing Issue microsoft#3707 - OverflowSet: Add the ability to set aria-label (microsoft#4667) Fix input type for Tile ARIA label prop (microsoft#4668) Fix theme slots for DetailsList header colors (microsoft#4658) Applying package updates. Jolore/calendar updates (microsoft#4643) Remove wordWrap setting. (microsoft#4657) Pivot: convert to mergeStyles - part 1 (microsoft#4656) Use the `data-is-scrollable` attribute on the correct ScrollablePane div (microsoft#4602) Applying package updates. Remove unused iconClassName prop from Nav.types (microsoft#4634) Jest snapshots: classes in animations should autoexpand. (microsoft#4647) ...
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Apr 26, 2018
* master: (34 commits) Applying package updates. ProgressIndicator: Finish conversion to mergeStyles (microsoft#4595) Fix props validation for Breadcrumb (microsoft#4666) No unused vars part of ts (microsoft#4670) Picker/Autofill: fixes several minor bugs. (microsoft#4569) Fix Calendar component PREV/NEXT month, year, and "Go to today" handlers firing twice (microsoft#4662) Applying package updates. Merge styles order (microsoft#4664) Fabric component: revert class change and make it backwards compatible (microsoft#4671) Addressing Issue microsoft#3707 - OverflowSet: Add the ability to set aria-label (microsoft#4667) Fix input type for Tile ARIA label prop (microsoft#4668) Fix theme slots for DetailsList header colors (microsoft#4658) Applying package updates. Jolore/calendar updates (microsoft#4643) Remove wordWrap setting. (microsoft#4657) Pivot: convert to mergeStyles - part 1 (microsoft#4656) Use the `data-is-scrollable` attribute on the correct ScrollablePane div (microsoft#4602) Applying package updates. Remove unused iconClassName prop from Nav.types (microsoft#4634) Jest snapshots: classes in animations should autoexpand. (microsoft#4647) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
barHeightprop for customizing progress bar height. Defaults to 2.animationtoIRawStyleBasein order to use animation shorthand.Focus areas to test