Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverflowSet: Add the ability to set aria-label #3707

Closed
jspurlin opened this issue Jan 11, 2018 · 2 comments · Fixed by #4667
Closed

OverflowSet: Add the ability to set aria-label #3707

jspurlin opened this issue Jan 11, 2018 · 2 comments · Fixed by #4667
Assignees
@oengusmacinog-zz
Labels
Component: OverflowSet Type: Feature

Comments

@jspurlin
Copy link
Contributor

Bug Report

  • Package version(s): 5.39.0

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? Yes

Requested priority: Normal

Products/sites affected: Office Online

Describe the issue:

Currently there's no way to set aria-label for the OverflowSet outside of passing the properties through on the FocusZoneProps prop, which isn't the best. We should consider allowing any html attributes to make a more broad solution to this problem
@stale
Copy link

stale bot commented Apr 11, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to Fabric React!

@oengusmacinog-zz oengusmacinog-zz mentioned this issue Apr 24, 2018
Merged
2 tasks
@oengusmacinog-zz
Copy link
Collaborator

@jspurlin there's a PR open now to allow native props all of the time now, but if it helps they actually are available now if you use the doNotContainWithinFocusZone and set it to true.

dzearing pushed a commit that referenced this issue Apr 25, 2018
@oengusmacinog-zz @dzearing
Addressing Issue #3707 - OverflowSet: Add the ability to set aria-lab…
127d4d9 
…el (#4667)

* enabled native props with use of FocusZone

* added documentation for native props to OverflowSet

* rush change
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this issue Apr 26, 2018
@Markionium
Merge branch 'master' into mapol/noGlobalClassNames
4196e29 
* master: (42 commits)
  Applying package updates.
  ProgressIndicator: Finish conversion to mergeStyles (microsoft#4595)
  Fix props validation for Breadcrumb (microsoft#4666)
  No unused vars part of ts (microsoft#4670)
  Picker/Autofill: fixes several minor bugs. (microsoft#4569)
  Fix Calendar component PREV/NEXT month, year, and "Go to today" handlers firing twice (microsoft#4662)
  Applying package updates.
  Merge styles order (microsoft#4664)
  Fabric component: revert class change and make it backwards compatible (microsoft#4671)
  Addressing Issue microsoft#3707 - OverflowSet: Add the ability to set aria-label (microsoft#4667)
  Fix input type for Tile ARIA label prop (microsoft#4668)
  Fix theme slots for DetailsList header colors (microsoft#4658)
  Applying package updates.
  Jolore/calendar updates (microsoft#4643)
  Remove wordWrap setting. (microsoft#4657)
  Pivot: convert to mergeStyles - part 1  (microsoft#4656)
  Use the `data-is-scrollable` attribute on the correct ScrollablePane div (microsoft#4602)
  Applying package updates.
  Remove unused iconClassName prop from Nav.types (microsoft#4634)
  Jest snapshots: classes in animations should autoexpand. (microsoft#4647)
  ...
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this issue Apr 26, 2018
@Markionium
Merge branch 'master' into mapol/allow-overriding-root-element-on-link
6f05b43 
* master: (34 commits)
  Applying package updates.
  ProgressIndicator: Finish conversion to mergeStyles (microsoft#4595)
  Fix props validation for Breadcrumb (microsoft#4666)
  No unused vars part of ts (microsoft#4670)
  Picker/Autofill: fixes several minor bugs. (microsoft#4569)
  Fix Calendar component PREV/NEXT month, year, and "Go to today" handlers firing twice (microsoft#4662)
  Applying package updates.
  Merge styles order (microsoft#4664)
  Fabric component: revert class change and make it backwards compatible (microsoft#4671)
  Addressing Issue microsoft#3707 - OverflowSet: Add the ability to set aria-label (microsoft#4667)
  Fix input type for Tile ARIA label prop (microsoft#4668)
  Fix theme slots for DetailsList header colors (microsoft#4658)
  Applying package updates.
  Jolore/calendar updates (microsoft#4643)
  Remove wordWrap setting. (microsoft#4657)
  Pivot: convert to mergeStyles - part 1  (microsoft#4656)
  Use the `data-is-scrollable` attribute on the correct ScrollablePane div (microsoft#4602)
  Applying package updates.
  Remove unused iconClassName prop from Nav.types (microsoft#4634)
  Jest snapshots: classes in animations should autoexpand. (microsoft#4647)
  ...
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@oengusmacinog-zz oengusmacinog-zz

Labels
Component: OverflowSet Type: Feature
Projects
None yet
Milestone
No milestone
4 participants
@gokunymbus @micahgodbolt @oengusmacinog-zz @jspurlin