Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate bot config to yml #28981

Merged
merged 2 commits into from
Aug 25, 2023
Merged

chore: Migrate bot config to yml #28981

merged 2 commits into from
Aug 25, 2023

Conversation

sopranopillow
Copy link
Contributor

Previous Behavior

The bot stopped working due to its decommissioning and its configuration hasn't been merged (that configuration doesn't work anymore) #26184.

New Behavior

Migrate to yaml the config from above and this should enable back the bot.

@sopranopillow sopranopillow requested a review from a team as a code owner August 24, 2023 22:13
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 24, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d3e042e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 24, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 74 71 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 624 625 5000
Button mount 318 321 5000
Field mount 1080 1106 5000
FluentProvider mount 679 683 5000
FluentProviderWithTheme mount 74 71 10 Possible regression
FluentProviderWithTheme virtual-rerender 72 72 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 73 10
InfoButton mount 9 16 5000
MakeStyles mount 825 845 50000
Persona mount 1727 1714 5000
SpinButton mount 1352 1362 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 24, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 24, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
DividerMinimalPerf.default 213 196 1.09:1
FormMinimalPerf.default 240 223 1.08:1
ListNestedPerf.default 350 325 1.08:1
ListWith60ListItems.default 383 356 1.08:1
ReactionMinimalPerf.default 216 204 1.06:1
AlertMinimalPerf.default 158 150 1.05:1
AnimationMinimalPerf.default 295 280 1.05:1
BoxMinimalPerf.default 197 187 1.05:1
TextMinimalPerf.default 193 183 1.05:1
VideoMinimalPerf.default 437 418 1.05:1
AttachmentMinimalPerf.default 88 85 1.04:1
CarouselMinimalPerf.default 259 249 1.04:1
ListMinimalPerf.default 308 297 1.04:1
MenuMinimalPerf.default 501 481 1.04:1
IconMinimalPerf.default 375 359 1.04:1
TreeMinimalPerf.default 495 477 1.04:1
ChatDuplicateMessagesPerf.default 146 142 1.03:1
LabelMinimalPerf.default 220 214 1.03:1
SegmentMinimalPerf.default 197 192 1.03:1
CustomToolbarPrototype.default 1521 1474 1.03:1
CardMinimalPerf.default 305 298 1.02:1
CheckboxMinimalPerf.default 1154 1127 1.02:1
EmbedMinimalPerf.default 1907 1869 1.02:1
ItemLayoutMinimalPerf.default 721 708 1.02:1
ListCommonPerf.default 392 384 1.02:1
LoaderMinimalPerf.default 188 185 1.02:1
MenuButtonMinimalPerf.default 974 956 1.02:1
RadioGroupMinimalPerf.default 269 264 1.02:1
ButtonMinimalPerf.default 86 85 1.01:1
DatepickerMinimalPerf.default 3564 3535 1.01:1
DropdownMinimalPerf.default 1420 1407 1.01:1
HeaderMinimalPerf.default 214 212 1.01:1
PopupMinimalPerf.default 350 348 1.01:1
ProviderMergeThemesPerf.default 667 660 1.01:1
AccordionMinimalPerf.default 84 84 1:1
AttachmentSlotsPerf.default 628 627 1:1
ButtonSlotsPerf.default 302 302 1:1
DropdownManyItemsPerf.default 384 383 1:1
RosterPerf.default 1562 1556 1:1
ProviderMinimalPerf.default 204 204 1:1
TextAreaMinimalPerf.default 294 294 1:1
GridMinimalPerf.default 185 186 0.99:1
HeaderSlotsPerf.default 469 475 0.99:1
InputMinimalPerf.default 554 557 0.99:1
SplitButtonMinimalPerf.default 2208 2228 0.99:1
TableManyItemsPerf.default 1103 1112 0.99:1
TooltipMinimalPerf.default 1256 1264 0.99:1
TreeWith60ListItems.default 86 87 0.99:1
ChatMinimalPerf.default 432 439 0.98:1
DialogMinimalPerf.default 442 450 0.98:1
PortalMinimalPerf.default 86 88 0.98:1
RefMinimalPerf.default 107 109 0.98:1
SliderMinimalPerf.default 740 752 0.98:1
TableMinimalPerf.default 238 244 0.98:1
ButtonOverridesMissPerf.default 635 658 0.97:1
ImageMinimalPerf.default 223 229 0.97:1
ToolbarMinimalPerf.default 530 546 0.97:1
ChatWithPopoverPerf.default 185 193 0.96:1
StatusMinimalPerf.default 395 414 0.95:1
AvatarMinimalPerf.default 99 105 0.94:1
FlexMinimalPerf.default 146 155 0.94:1
LayoutMinimalPerf.default 189 208 0.91:1
SkeletonMinimalPerf.default 184 223 0.83:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 24, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
330 B
global-context
createContextSelector		 537 B
342 B
priority-overflow
createOverflowManager		 4.162 kB
1.735 kB
react-accordion
Accordion (including children components)		 88.688 kB
26.917 kB
react-alert
Alert		 81.836 kB
22.031 kB
react-avatar
Avatar		 47.01 kB
14.502 kB
react-avatar
AvatarGroup		 16.116 kB
6.431 kB
react-avatar
AvatarGroupItem		 61.789 kB
18.912 kB
react-badge
Badge		 23.183 kB
7.254 kB
react-badge
CounterBadge		 24.084 kB
7.553 kB
react-badge
PresenceBadge		 22.14 kB
7.867 kB
react-button
Button		 37.078 kB
9.751 kB
react-button
CompoundButton		 44.427 kB
11.234 kB
react-button
MenuButton		 41.464 kB
11.001 kB
react-button
SplitButton		 49.499 kB
12.555 kB
react-button
ToggleButton		 54.124 kB
11.65 kB
react-card
Card - All		 88.334 kB
25.252 kB
react-card
Card		 83.177 kB
23.742 kB
react-card
CardFooter		 9.338 kB
3.932 kB
react-card
CardHeader		 11.589 kB
4.707 kB
react-card
CardPreview		 10.297 kB
4.317 kB
react-checkbox
Checkbox		 32.872 kB
10.652 kB
react-combobox
Combobox (including child components)		 87.101 kB
28.273 kB
react-combobox
Dropdown (including child components)		 85.555 kB
27.926 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 66.614 kB
18.512 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 203.786 kB
57.921 kB
react-components
react-components: FluentProvider & webLightTheme		 37.787 kB
12.387 kB
react-datepicker-compat
DatePicker Compat		 207.372 kB
57.465 kB
react-dialog
Dialog (including children components)		 86.738 kB
26.341 kB
react-divider
Divider		 17.098 kB
6.303 kB
react-field
Field		 18.295 kB
6.978 kB
react-image
Image		 12.029 kB
4.783 kB
react-infobutton
InfoButton		 125.55 kB
39.359 kB
react-infobutton
InfoLabel		 129.221 kB
40.532 kB
react-input
Input		 23.237 kB
7.688 kB
react-jsx-runtime
Classic Pragma		 1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime		 2.752 kB
1.277 kB
react-jsx-runtime
JSX Runtime		 3.27 kB
1.519 kB
react-label
Label		 10.423 kB
4.31 kB
react-link
Link		 13.254 kB
5.397 kB
react-menu
Menu (including children components)		 135.737 kB
41.647 kB
react-menu
Menu (including selectable components)		 138.423 kB
42.149 kB
react-overflow
hooks only		 12.419 kB
4.687 kB
react-persona
Persona		 53.905 kB
16.371 kB
react-popover
Popover		 114.822 kB
36 kB
react-portal
Portal		 12.255 kB
4.504 kB
react-portal-compat
PortalCompatProvider		 6.48 kB
2.203 kB
react-positioning
usePositioning		 25.137 kB
9.109 kB
react-progress
ProgressBar		 13.718 kB
5.476 kB
react-provider
FluentProvider		 18.332 kB
6.817 kB
react-radio
Radio		 26.617 kB
8.601 kB
react-radio
RadioGroup		 11.622 kB
4.833 kB
react-select
Select		 24.599 kB
8.651 kB
react-slider
Slider		 34.134 kB
11.039 kB
react-spinbutton
SpinButton		 32.773 kB
10.216 kB
react-spinner
Spinner		 19.668 kB
7.024 kB
react-switch
Switch		 29.092 kB
9.217 kB
react-table
DataGrid		 152.991 kB
42.325 kB
react-table
Table (Primitives only)		 39.638 kB
12.129 kB
react-table
Table as DataGrid		 126.247 kB
33.617 kB
react-table
Table (Selection only)		 71.617 kB
18.915 kB
react-table
Table (Sort only)		 70.236 kB
18.516 kB
react-tags-preview
InteractionTag		 11.031 kB
4.528 kB
react-tags-preview
Tag		 28.65 kB
9.018 kB
react-tags-preview
TagGroup		 69.607 kB
20.482 kB
react-text
Text - Default		 13.043 kB
5.129 kB
react-text
Text - Wrappers		 16.215 kB
5.447 kB
react-textarea
Textarea		 27.302 kB
9.047 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 34.611 kB
7.295 kB
react-theme
Teams: Light theme		 19.282 kB
5.486 kB
react-toast
Toast (including Toaster)		 87.69 kB
26.037 kB
react-tooltip
Tooltip		 48.1 kB
16.875 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 727a5dfc487ff37a26fa37226319dbe80eb02fcb

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 24, 2023 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Aug 24, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 727a5dfc487ff37a26fa37226319dbe80eb02fcb (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 24, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 638 637 5000
Breadcrumb mount 1675 1662 1000
Checkbox mount 1678 1703 5000
CheckboxBase mount 1478 1439 5000
ChoiceGroup mount 2963 2911 5000
ComboBox mount 662 656 1000
CommandBar mount 6109 6127 1000
ContextualMenu mount 11885 12149 1000
DefaultButton mount 753 733 5000
DetailsRow mount 2167 2179 5000
DetailsRowFast mount 2160 2158 5000
DetailsRowNoStyles mount 2029 2018 5000
Dialog mount 2585 2598 1000
DocumentCardTitle mount 228 220 1000
Dropdown mount 1984 1973 5000
FocusTrapZone mount 1116 1118 5000
FocusZone mount 1054 1066 5000
GroupedList mount 41217 41480 2
GroupedList virtual-rerender 19861 19722 2
GroupedList virtual-rerender-with-unmount 50472 50602 2
GroupedListV2 mount 212 224 2
GroupedListV2 virtual-rerender 206 212 2
GroupedListV2 virtual-rerender-with-unmount 227 222 2
IconButton mount 1095 1087 5000
Label mount 332 334 5000
Layer mount 2672 2680 5000
Link mount 377 392 5000
MenuButton mount 953 959 5000
MessageBar mount 21422 21422 5000
Nav mount 1914 1878 1000
OverflowSet mount 770 789 5000
Panel mount 1745 1754 1000
Persona mount 735 752 1000
Pivot mount 873 862 1000
PrimaryButton mount 846 840 5000
Rating mount 4614 4599 5000
SearchBox mount 902 916 5000
Shimmer mount 1917 1864 5000
Slider mount 1318 1332 5000
SpinButton mount 2847 2813 5000
Spinner mount 393 390 5000
SplitButton mount 1816 1818 5000
Stack mount 408 406 5000
StackWithIntrinsicChildren mount 854 840 5000
StackWithTextChildren mount 2597 2642 5000
SwatchColorPicker mount 6145 6170 5000
TagPicker mount 1424 1474 5000
Text mount 364 369 5000
TextField mount 927 906 5000
ThemeProvider mount 819 824 5000
ThemeProvider virtual-rerender 593 578 5000
ThemeProvider virtual-rerender-with-unmount 1263 1248 5000
Toggle mount 598 597 5000
buttonNative mount 184 183 5000

@sopranopillow sopranopillow enabled auto-merge (squash) August 25, 2023 17:40
@sopranopillow sopranopillow merged commit e1d711f into microsoft:master Aug 25, 2023
@sopranopillow sopranopillow deleted the bot-revival branch August 25, 2023 18:27
@sopranopillow sopranopillow mentioned this pull request Aug 25, 2023
Closed
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/add-motion-to-drawer
8976c76 
* master: (23 commits)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  Focus indicator bug in bar charts (microsoft#28414)
  Pie chart focus spacing (microsoft#28504)
  applying package updates
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/ignore-motion-when-reduced-motion-is-on
b8f6e51 
* master: (24 commits)
  feat(react-motion): add useMotion hook (microsoft#28699)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  Focus indicator bug in bar charts (microsoft#28414)
  Pie chart focus spacing (microsoft#28504)
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-motion
7606af3 
* master: (24 commits)
  feat(react-motion): add useMotion hook (microsoft#28699)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  Focus indicator bug in bar charts (microsoft#28414)
  Pie chart focus spacing (microsoft#28504)
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/react-toast-use-motion
0437940 
* master: (26 commits)
  chore: Make triage bot add needs triage label to new issues (microsoft#28994)
  fix(react-tags-preview): use regular icon for dismiss (microsoft#28958)
  feat(react-motion): add useMotion hook (microsoft#28699)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@micahgodbolt micahgodbolt micahgodbolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sopranopillow @fabricteam @micahgodbolt