Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus indicator bug in bar charts #28414

Merged
merged 54 commits into from
Aug 24, 2023
Merged

Focus indicator bug in bar charts #28414

merged 54 commits into from
Aug 24, 2023

Conversation

yush-singla
Copy link
Contributor

@yush-singla yush-singla commented Jul 3, 2023 •
edited
Loading

Work Item -> https://uifabric.visualstudio.com/iss/_workitems/edit/8180

Previous Behavior

The horizontal bar chart and the multi stacked bar chart's focus indicator had a bug where all the 4 sides were not visible.

image
image

New Behavior

The Bug has been patched, and the focus indicator is visible on all 4 sides properly now

image
image

Related Issue(s)

singlayush and others added 12 commits June 28, 2023 13:57
@singlayush
focus indicator bug fix in bar chart
e645d0e
@singlayush
added bars spacing adjustment factor
543b005
@singlayush
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
ab9e8fa 
…ocus-bug
@singlayush
resolving eslint issues
b31bd7c
@singlayush
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
a612f24 
…ocus-bug
@singlayush
updated snapshots, for horizontal bar chart and multistacked bar chart
9fbe4f3
@singlayush
pixel design issue fixed
afb9f64
@yush-singla
Merge branch 'master' into focus-bug
050e36f
@singlayush
snapshot updated
ef4a855
@singlayush
Merge branch 'focus-bug' of https://github.com/yush-singla/fluentui i…
376a20e 
…nto focus-bug
@singlayush
added change, and fixed stroke thickness in horizontal bar chart
7763568
@singlayush
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
0a829fc 
…ocus-indicator-bug
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 3, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 44789c103b2c4a05c026c72f4a594a291fdb0141

@size-auditor
Copy link

size-auditor bot commented Jul 3, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 44789c103b2c4a05c026c72f4a594a291fdb0141 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 3, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b638967:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@yush-singla yush-singla marked this pull request as ready for review July 4, 2023 04:11
@yush-singla yush-singla requested a review from a team as a code owner July 4, 2023 04:11
@AtishayMsft
Copy link
Contributor

/azp run Fluent UI React - PR and CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

AtishayMsft
AtishayMsft requested changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@AtishayMsft AtishayMsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is reproing for stacked bar chart as well.

@AtishayMsft AtishayMsft merged commit 78808a4 into microsoft:master Aug 24, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/add-motion-to-drawer
8976c76 
* master: (23 commits)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  Focus indicator bug in bar charts (microsoft#28414)
  Pie chart focus spacing (microsoft#28504)
  applying package updates
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/ignore-motion-when-reduced-motion-is-on
b8f6e51 
* master: (24 commits)
  feat(react-motion): add useMotion hook (microsoft#28699)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  Focus indicator bug in bar charts (microsoft#28414)
  Pie chart focus spacing (microsoft#28504)
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-motion
7606af3 
* master: (24 commits)
  feat(react-motion): add useMotion hook (microsoft#28699)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  Focus indicator bug in bar charts (microsoft#28414)
  Pie chart focus spacing (microsoft#28504)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@AtishayMsft AtishayMsft AtishayMsft approved these changes

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yush-singla @fabricteam @AtishayMsft @tomi-msft @msft-fluent-ui-bot @singlayush