Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fabricbot config to repo #26184

Closed
wants to merge 4 commits into from

Conversation

micahgodbolt
Copy link
Member

@micahgodbolt micahgodbolt commented Jan 5, 2023

fabricbot is moving to code base configuration, as they have removed the ability to edit rules inside of their UI.

This PR only introduces the config as it is today. Future changes will be made in subsequent PRs.

@JustSlone
Copy link
Collaborator

Is there anything we need to do to disable the config that is stored in the service before we merge this in?

Also, if we think there is risk of this not working, it would be safer to bring in the config as, then follow up with a PR to change the config.

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 5, 2023

📊 Bundle size report

🤖 This report was generated against 4896e260ed3bd50d70c70106531e771a898cd97a

@size-auditor
Copy link

size-auditor bot commented Jan 5, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: af59ca53d4dfa7e6d80f37002ddcd4107d32b8fa (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c5aafd7:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@micahgodbolt
Copy link
Member Author

i'm ok with the idea of splitting this up. If something goes wrong it'll be easier to discect

@JustSlone
Copy link
Collaborator

Is there anything we need to do to disable the config that is stored in the service before we merge this in?

Do we know the answer to this? Are we going to get duplicate rules running if we merge this in?

@micahgodbolt
Copy link
Member Author

Is there anything we need to do to disable the config that is stored in the service before we merge this in?

Do we know the answer to this? Are we going to get duplicate rules running if we merge this in?

From reading the instructions I'm confident that this is the approach we have to take in order to modify our rules in the future. There is no other way to modify, change, remove, add rules to the existing ruleset other than this file.

@DragosDanielBoia
Copy link
Member

hi @micahgodbolt can we get this merge into master, I'm from the FabricBot team, we took over the system and in order to move forward you will need to have this into the default branch,

@Hotell
Copy link
Contributor

Hotell commented Apr 18, 2023

this bot started to block all our PRs caused by auto-merge.config.enforce - we removed that check from master protection rules to unblock contributions. Is this change somehow related ( the migration of the bot config etc )?

This config is quite gigantic without any docs etc, how are we gonna maintain this ?

Future changes will be made in subsequent PRs

can you elaborate more about what "future changes" are you referring ?

@sopranopillow
Copy link
Contributor

This config was added in the new yml format per #28981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants