Table/DataGrid: keyboard resizing improvements #28493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 74 | 84 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 594 | 577 | 5000 | |
| Button | mount | 303 | 291 | 5000 | |
| Field | mount | 1011 | 1063 | 5000 | |
| FluentProvider | mount | 653 | 630 | 5000 | |
| FluentProviderWithTheme | mount | 74 | 84 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 65 | 69 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 71 | 73 | 10 | |
| InfoButton | mount | 10 | 12 | 5000 | |
| MakeStyles | mount | 863 | 831 | 50000 | |
| Persona | mount | 1646 | 1604 | 5000 | |
| SpinButton | mount | 1340 | 1336 | 5000 |
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Jul 11, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 46fa55f:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 67204719005015e0af0e272fd86d44fc02e1e0a0 (build) |
fabricteam
reviewed
Jul 13, 2023
ling1726
reviewed
Jul 18, 2023
...components/react-table/src/components/TableResizeHandle/useTableResizeHandleStyles.styles.ts
Show resolved
Hide resolved
ling1726
reviewed
Jul 18, 2023
packages/react-components/react-table/stories/DataGrid/KeyboardColumnResizing.stories.tsx
Show resolved
Hide resolved
ling1726
reviewed
Jul 18, 2023
packages/react-components/react-table/src/hooks/useKeyboardResizing.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Jul 18, 2023
packages/react-components/react-table/src/hooks/useKeyboardResizing.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Jul 18, 2023
packages/react-components/react-table/src/hooks/useKeyboardResizing.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Jul 21, 2023
packages/react-components/react-table/src/hooks/useKeyboardResizing.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Jul 21, 2023
...components/react-table/src/components/TableResizeHandle/useTableResizeHandleStyles.styles.ts
Outdated
Show resolved
Hide resolved
…e-keyboard-resize-improvements
ling1726
approved these changes
Jul 24, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 25, 2023
* master: (32 commits) chore: remove @fluentui/bundle-size (microsoft#28601) Breadcrumb UI adjustments (microsoft#28578) feat(tools): re-generate react-components.api.md when preparing 1st stable release (microsoft#28561) perf(tools): make dependency-mismatch execution 90% faster and ignore */>=9.0.0-alpha versions (microsoft#28597) Table/DataGrid: keyboard resizing improvements (microsoft#28493) docs(react-tooltip): Add info icon + tooltip story to Tooltip stories (microsoft#28611) chore: Updating @fluentui/react-icons to version 2.0.207 (microsoft#28590) feat: allSelectedRows and someSelectedRows should be more reliable (microsoft#28577) add vr test to react-tags (microsoft#28484) applying package updates chore: migrate to monosize (microsoft#26826) fix(react-conformance): add @swc/helpers to deps instead of tslib as we use swc for transpilation (microsoft#28599) fix: MenuItem content should be spaced 12px from the boundary (microsoft#28162) feat: implements selection (microsoft#28497) bugfix: moves handleBackdropClick from defaultProps to an override (microsoft#28579) Fix empty CSS creation (microsoft#28566) chore: replace plop with nx within create-* aliases in root package.json (microsoft#28575) applying package updates fix: High contrast mode hover style icon fixes in react-button components (microsoft#28156) SplitButton: updated border right token for primary variant (microsoft#28555) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Previously when keyboard column resizing was enabled, the focus would be moved to the body to avoid conflict with Tabster. This has some downsides specifically when screen readers are being used.
New Behavior
The new behavior keeps the focus on the resize handle while user is resizing with the arrows. To make sure the handle is not focusable, the handles initially have no tabIndex. The tabIndex is then set to 0 when the keyboard resizing is enabled, and the handle is focused. This is reverted when the handle is blurred, or ESC, Space or Enter are pressed during the keyboard resizing.
The handle also now has a "separator" role, which is more in line to what we would expect for screen reader support. As the columns are resized, the current width is read in real time.
I also removed some of the support code for the previous solution and its workarounds.
Related Issue(s)