fix: MenuItem content should be spaced 12px from the boundary #28162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should be 12px spacing between the start of a MenuItem content and the MenuPopover. Currently there is 17px. This is caused by: - 1px transparent border for high contrast mode - This renders before the box-shadow making the MenuPopvoer 'wider' - incorrect 10px padding on the MenuItem This PR: - Changes the MenuItem padding to 6px - Changes the MenuPopover padding to 3px to account for the 1px transparent border. The MenuItem `content` slot has a padding of 2px to align with the v9 icon 2px bounding box. 2px + 6px + 3px + 1px = 12px
8c4c1c8 to
0c353b1
Compare
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 586 | 632 | 5000 | |
| Button | mount | 303 | 298 | 5000 | |
| Field | mount | 1059 | 1048 | 5000 | |
| FluentProvider | mount | 637 | 653 | 5000 | |
| FluentProviderWithTheme | mount | 87 | 84 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 65 | 70 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 82 | 10 | |
| InfoButton | mount | 11 | 9 | 5000 | |
| MakeStyles | mount | 847 | 861 | 50000 | |
| Persona | mount | 1636 | 1601 | 5000 | |
| SpinButton | mount | 1283 | 1310 | 5000 |
Asset size changes
Baseline commit: 820b2c5b432f0f72df241c197b8cc0f5112657b3 (build) |
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4bdddbb:
|
fabricteam
reviewed
Jun 7, 2023
fabricteam
reviewed
Jul 14, 2023
bsunderhus
approved these changes
Jul 20, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 25, 2023
* master: (32 commits) chore: remove @fluentui/bundle-size (microsoft#28601) Breadcrumb UI adjustments (microsoft#28578) feat(tools): re-generate react-components.api.md when preparing 1st stable release (microsoft#28561) perf(tools): make dependency-mismatch execution 90% faster and ignore */>=9.0.0-alpha versions (microsoft#28597) Table/DataGrid: keyboard resizing improvements (microsoft#28493) docs(react-tooltip): Add info icon + tooltip story to Tooltip stories (microsoft#28611) chore: Updating @fluentui/react-icons to version 2.0.207 (microsoft#28590) feat: allSelectedRows and someSelectedRows should be more reliable (microsoft#28577) add vr test to react-tags (microsoft#28484) applying package updates chore: migrate to monosize (microsoft#26826) fix(react-conformance): add @swc/helpers to deps instead of tslib as we use swc for transpilation (microsoft#28599) fix: MenuItem content should be spaced 12px from the boundary (microsoft#28162) feat: implements selection (microsoft#28497) bugfix: moves handleBackdropClick from defaultProps to an override (microsoft#28579) Fix empty CSS creation (microsoft#28566) chore: replace plop with nx within create-* aliases in root package.json (microsoft#28575) applying package updates fix: High contrast mode hover style icon fixes in react-button components (microsoft#28156) SplitButton: updated border right token for primary variant (microsoft#28555) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be 12px spacing between the start of a MenuItem content and the MenuPopover. Currently there is 17px. This is caused by:
This PR:
The MenuItem
contentslot has a padding of 2px to align with the v9 icon 2px bounding box. 2px + 6px + 3px + 1px = 12px