Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vr test to react-tags #28484

Merged
merged 9 commits into from
Jul 21, 2023
Merged

Conversation

YuanboXue-Amber
Copy link
Contributor

@YuanboXue-Amber YuanboXue-Amber commented Jul 10, 2023

Add VR test as part of #26001

TODO in follow up PRs - add more tests for:
Tag/InteractionTag appearances with hover/pressed.
Tag/InteractionTag shapes with focus ring.

@size-auditor
Copy link

size-auditor bot commented Jul 10, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c3819e59d69a017c61f39d617b84a0fff6cd9fff (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 10, 2023

📊 Bundle size report

🤖 This report was generated against c3819e59d69a017c61f39d617b84a0fff6cd9fff

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5ee61e2:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review July 19, 2023 16:22
@YuanboXue-Amber YuanboXue-Amber requested a review from a team as a code owner July 19, 2023 16:22
@YuanboXue-Amber YuanboXue-Amber merged commit 603d067 into microsoft:master Jul 21, 2023
@YuanboXue-Amber YuanboXue-Amber deleted the tag-vr branch July 21, 2023 09:58
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jul 25, 2023
* master: (32 commits)
  chore: remove @fluentui/bundle-size (microsoft#28601)
  Breadcrumb UI adjustments (microsoft#28578)
  feat(tools): re-generate react-components.api.md when preparing 1st stable release (microsoft#28561)
  perf(tools): make dependency-mismatch execution 90% faster and ignore */>=9.0.0-alpha versions (microsoft#28597)
  Table/DataGrid: keyboard resizing improvements (microsoft#28493)
  docs(react-tooltip): Add info icon + tooltip story to Tooltip stories (microsoft#28611)
  chore: Updating @fluentui/react-icons to version 2.0.207 (microsoft#28590)
  feat: allSelectedRows and someSelectedRows should be more reliable (microsoft#28577)
  add vr test to react-tags (microsoft#28484)
  applying package updates
  chore: migrate to monosize (microsoft#26826)
  fix(react-conformance): add @swc/helpers to deps instead of tslib as we use swc for transpilation (microsoft#28599)
  fix: MenuItem content should be spaced 12px from the boundary (microsoft#28162)
  feat: implements selection (microsoft#28497)
  bugfix: moves handleBackdropClick from defaultProps to an override (microsoft#28579)
  Fix empty CSS creation (microsoft#28566)
  chore: replace plop with nx within create-* aliases in root package.json (microsoft#28575)
  applying package updates
  fix: High contrast mode hover style icon fixes in react-button components (microsoft#28156)
  SplitButton: updated border right token for primary variant (microsoft#28555)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants