Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] add an allgood job for easy [required] builds #3351

Merged
merged 3 commits into from
Sep 6, 2020
Merged

[ci] add an allgood job for easy [required] builds #3351

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29428b9
add an allgood job for easy [required] builds
graingert Sep 4, 2020
4ab7541
Update .github/workflows/main.yml
graingert Sep 4, 2020
bf51847
Update .github/workflows/main.yml
jameslamb Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,3 +160,10 @@ jobs:
$env:TASK = "${{ matrix.task }}"
conda init powershell
& "$env:GITHUB_WORKSPACE/.ci/test_windows.ps1"
all-successful:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graingert FYI this check may be problematic with failures and branch protection. Here's a more comprehensive solution: https://github.com/re-actors/alls-green.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice one!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be more specific? How might this cause problems with branch protection?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danepowell it's explained at https://github.com/marketplace/actions/alls-green#why but TL;DR — when some job dependencies fail, this job may end up being skipped and branch protection treats skipped jobs as success.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also filed #5501.

# https://github.uint.cloudmunity/t/is-it-possible-to-require-all-github-actions-tasks-to-pass-without-enumerating-them/117957/4?u=graingert
runs-on: ubuntu-latest
needs: [test]
steps:
- name: note that all tests succeeded
run: echo "🎉"