Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Problematic all-successful GHA job implementation #5501

Closed
webknjaz opened this issue Sep 24, 2022 · 1 comment · Fixed by #5645
Closed

[ci] Problematic all-successful GHA job implementation #5501

webknjaz opened this issue Sep 24, 2022 · 1 comment · Fixed by #5645
Assignees

Comments

@webknjaz
Copy link

[a drive-by advice]

Hi, I noticed that you have an all-successful job in the workflows. The idea is great but the way it's implemented may let broken changes slip through. There are corner cases when this job would be marked as skipped which branch protection would interpret as "not red, good to go". To solve this properly, it'd have to run with if: always() and enumerate+check statuses of each dependency-job.
This is a lot more work so I've generalized all necessary in an action @ https://github.com/marketplace/actions/alls-green#why.

Another problem I foresee is that there' multiple workflows reporting the same job name all-successful so if it happens that some workflows succeed but others fail (or would be slow) to post a status (hello, eventual consistency of GH), it'd also allow merging broken changes. I normally recommend having unique check/gate job names per workflow because of this.

@jameslamb jameslamb changed the title [CI] Problematic all-successful GHA job implementation [ci] Problematic all-successful GHA job implementation Dec 23, 2022
@jameslamb jameslamb self-assigned this Dec 23, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants