[ci] add an allgood job for easy [required] builds

[graingert]

see https://github.uint.cloudmunity/t/is-it-possible-to-require-all-github-actions-tasks-to-pass-without-enumerating-them/117957/4?u=graingert

[graingert]

@jameslamb you should be able to add "required" to GitHub Actions / allgood (pull_request) Successful in 1s

[StrikerRUS]

@graingert Thanks a lot! Indeed, this looks like something we were looking for!
Now we need just to mark this new job as required, right?

[jameslamb]

@StrikerRUS yeah, I think this is right: #3351 (review)

[StrikerRUS]

@graingert Thanks a lot for the workaround!

And thanks for making wordings easier to understand, LGTM!

[jameslamb]

works for me, thanks!

@StrikerRUS @guolinke I'll switch the set of required checks after merging

[jameslamb]

oh nevermind, it looks like I don't have access to change the required checks.

@guolinke sorry to bother you, could you change the set of required checks for GitHub Actions? Now we only need to require the all-successful task and all others can be disabled. After that, we'll be able to add and remove jobs without needing you too change the settings again.

[guolinke]

@jameslamb no problem

[graingert]

Have a look at https://github.com/probot/settings it allows setting settings with PRs

…

On Sun, Sep 6, 2020, 03:22 Guolin Ke ***@***.***> wrote: @jameslamb <https://github.com/jameslamb> no problem — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3351 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADFATA2AJHTJ5PW7PXLDNDSELW65ANCNFSM4QXZB3VQ> .

[jameslamb]

thanks @graingert . We change these settings rarely enough that I think it's better to have them done manually than to have another integration to maintain.

[webknjaz]

@graingert FYI this check may be problematic with failures and branch protection. Here's a more comprehensive solution: https://github.com/re-actors/alls-green.

[graingert]

Ah nice one!

[danepowell]

Could you be more specific? How might this cause problems with branch protection?

[webknjaz]

@danepowell it's explained at https://github.com/marketplace/actions/alls-green#why but TL;DR — when some job dependencies fail, this job may end up being skipped and branch protection treats skipped jobs as success.

[webknjaz]

I've also filed #5501.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.