Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LG template displaying / editing problem in generated dialog #4989

Merged
merged 9 commits into from
Dec 3, 2020
Merged

fix: LG template displaying / editing problem in generated dialog #4989

merged 9 commits into from
Dec 3, 2020

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Nov 26, 2020 •
edited
Loading

Description

Integrate the ui-plugins 'lg' with Form Dialog feature.

Changes:

  • Flow UI Schema: enable creating 'Microsoft.Ask' and update the node UI
  • LG Displaying problem: get displayed lg text from all imported lg files rather than only the entry file
  • LG Editing problem: skip checking $designer.id when submitting new LG content

Notes:

  • No impact on non-form dialogs.
  • Deleting an Action won't delete the referenced LG template in another file for consideration of the case reference count > 0.

Remaining problems (won't be covered in this PR):

  1. generator-cli issue: needs to put lg comments after template name. needs to put lg comments below lg name declaration in form dialog generated lg files #4996
  2. LG all-up-view doesn't show imported lg templates. (Not tracked by an issue).

Task Item

Closes #4955

Screenshots

image
image
image
image

@coveralls
Copy link

coveralls commented Nov 26, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.203% when pulling c170c4e on zeye/formint into cf6e47a on main.

@yeze322 yeze322 marked this pull request as ready for review December 1, 2020 02:08
@cwhitten cwhitten merged commit 2fb9f59 into main Dec 3, 2020
@cwhitten cwhitten deleted the zeye/formint branch December 3, 2020 00:06
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@yeze322 @cosmicshuai @cwhitten
fix: LG template displaying / editing problem in generated dialog (mi…
644de50 
…crosoft#4989)

* add a lookup for the correct lgFile in lgField

* LgWdiget fallback to raw activity

* flow ui shema for Ask

* shared the query logic of lg tempalte

Co-authored-by: Shuai Wang <shuwan@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem of displaying and editing lg templates in generated Form Dialog
4 participants
@yeze322 @coveralls @cwhitten @cosmicshuai