Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs to put lg comments below lg name declaration in form dialog generated lg files #4996

Closed
8 tasks
yeze322 opened this issue Nov 26, 2020 · 1 comment
Closed
8 tasks
Assignees
Labels
Area: Form Dialogs The creation of an adaptive dialog from a schema defined by creating a form Type: Bug Something isn't working

Comments

@yeze322
Copy link
Contributor

yeze322 commented Nov 26, 2020

Describe the bug

Related to #4822 .
image

Before the fix, we need to make sure form dialog cli put lg comments below lg name declarations.

# arrivalDate_Show
>> Show value of 'arrivalDate' property
- ${arrivalDate_Name()}: ${arrivalDate_Value($arrivalDate)}

Rather than

>> Show value of 'arrivalDate' property
# arrivalDate_Show
- ${arrivalDate_Name()}: ${arrivalDate_Value($arrivalDate)}

Version

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Additional context

We can transfer this issue to Botbuilder-Samples repo after it's triaged.

@yeze322 yeze322 added Type: Bug Something isn't working Needs-triage A new issue that require triage Area: Form Dialogs The creation of an adaptive dialog from a schema defined by creating a form labels Nov 26, 2020
@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Dec 1, 2020
@hatpick
Copy link
Contributor

hatpick commented Dec 1, 2020

What do you think @chrimc62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Form Dialogs The creation of an adaptive dialog from a schema defined by creating a form Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants